From: Sasha Levin <sasha.levin@oracle.com>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
shli@kernel.org, Hugh Dickins <hughd@google.com>,
Rik van Riel <riel@redhat.com>, Shaohua Li <shli@fusionio.com>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [patch 019/154] mm: make madvise(MADV_WILLNEED) support swap file prefetch
Date: Mon, 16 Dec 2013 19:18:40 -0500 [thread overview]
Message-ID: <52AF9860.9000303@oracle.com> (raw)
In-Reply-To: <20131216205244.GG21218@redhat.com>
Hi Andrea,
On 12/16/2013 03:52 PM, Andrea Arcangeli wrote:
> Is the bug reproducible? If yes the simplest is probably to add some
> allocation tracking to the page, so if page->ptl is null we can simply
> print a stack trace of who allocated the page (and later forgot to
> initialize the ptl).
Yes, it's easy to reproduce. I've done as suggested and here's the trace from
the allocation:
[ 184.139519] [<ffffffff8107de0f>] save_stack_trace+0x2f/0x50
[ 184.140706] [<ffffffff81257769>] get_page_from_freelist+0x759/0x7a0
[ 184.141605] [<ffffffff81258438>] __alloc_pages_nodemask+0x3b8/0x520
[ 184.142810] [<ffffffff812a4baf>] alloc_pages_vma+0x1df/0x220
[ 184.143631] [<ffffffff812bcd58>] do_huge_pmd_wp_page+0x2d8/0x730
[ 184.144526] [<ffffffff81280e01>] __handle_mm_fault+0x2b1/0x3d0
[ 184.145361] [<ffffffff81281053>] handle_mm_fault+0x133/0x1c0
[ 184.146129] [<ffffffff812815f8>] __get_user_pages+0x448/0x640
[ 184.147055] [<ffffffff812827a4>] __mlock_vma_pages_range+0xd4/0xe0
[ 184.147980] [<ffffffff812828c0>] __mm_populate+0x110/0x190
[ 184.148933] [<ffffffff812839b2>] SyS_mlock+0xf2/0x130
[ 184.149689] [<ffffffff843c5e50>] tracesys+0xdd/0xe2
> Agree with Kirill that it would help to verify the bug goes away by
> disabling USE_SPLIT_PTE_PTLOCKS.
It seems that the bug is gone without USE_SPLIT_PTE_PTLOCKS.
Thanks,
Sasha
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-12-17 0:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130223003232.4CDDB5A41B6@corp2gmr1-2.hot.corp.google.com>
[not found] ` <52AA0613.2000908@oracle.com>
[not found] ` <CA+55aFw3_0_Et9bbfWgGLXEUaGQW1HE8j=oGBqFG_8j+h6jmvQ@mail.gmail.com>
[not found] ` <CA+55aFyRZW=Uy9w+bZR0vMOFNPqV-yW2Xs9N42qEwTQ3AY0fDw@mail.gmail.com>
[not found] ` <52AE271C.4040805@oracle.com>
2013-12-15 22:58 ` [patch 019/154] mm: make madvise(MADV_WILLNEED) support swap file prefetch Linus Torvalds
2013-12-16 12:47 ` Kirill A. Shutemov
2013-12-16 15:18 ` Sasha Levin
2013-12-16 20:52 ` Andrea Arcangeli
2013-12-17 0:18 ` Sasha Levin [this message]
2013-12-17 12:44 ` Kirill A. Shutemov
2013-12-17 14:09 ` Sasha Levin
2013-12-20 13:10 ` Kirill A. Shutemov
2013-12-20 13:31 ` Kirill A. Shutemov
2013-12-20 13:36 ` Kirill A. Shutemov
2013-12-20 17:42 ` Andrea Arcangeli
2013-12-23 10:25 ` Mel Gorman
2013-12-23 10:54 ` Kirill A. Shutemov
2013-12-23 11:15 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AF9860.9000303@oracle.com \
--to=sasha.levin@oracle.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
--cc=shli@fusionio.com \
--cc=shli@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).