From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f172.google.com (mail-ig0-f172.google.com [209.85.213.172]) by kanga.kvack.org (Postfix) with ESMTP id 3A9986B0037 for ; Thu, 30 Jan 2014 18:49:57 -0500 (EST) Received: by mail-ig0-f172.google.com with SMTP id k19so18779995igc.5 for ; Thu, 30 Jan 2014 15:49:57 -0800 (PST) Received: from merlin.infradead.org (merlin.infradead.org. [2001:4978:20e::2]) by mx.google.com with ESMTPS id q5si37651150igr.34.2014.01.30.15.49.56 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Jan 2014 15:49:56 -0800 (PST) Message-ID: <52EAE51D.4030709@infradead.org> Date: Thu, 30 Jan 2014 15:49:49 -0800 From: Randy Dunlap MIME-Version: 1.0 Subject: Re: [BUG] Description for memmap in kernel-parameters.txt is wrong References: <52EAA714.3080809@infradead.org> <52EAB56E.2030102@infradead.org> <52EAD810.40204@infradead.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Andiry Xu Cc: David Rientjes , Andiry Xu , linux-kernel@vger.kernel.org, Linux MM On 01/30/2014 03:43 PM, Andiry Xu wrote: > On Thu, Jan 30, 2014 at 2:54 PM, Randy Dunlap wrote: >> On 01/30/2014 02:17 PM, David Rientjes wrote: >>> On Thu, 30 Jan 2014, Randy Dunlap wrote: >>> >>>>>>> Hi, >>>>>>> >>>>>>> In kernel-parameters.txt, there is following description: >>>>>>> >>>>>>> memmap=nn[KMG]$ss[KMG] >>>>>>> [KNL,ACPI] Mark specific memory as reserved. >>>>>>> Region of memory to be used, from ss to ss+nn. >>>>>> >>>>>> Should be: >>>>>> Region of memory to be reserved, from ss to ss+nn. >>>>>> >>>>>> but that doesn't help with the problem that you describe, does it? >>>>>> >>>>> >>>>> Actually it should be: >>>>> Region of memory to be reserved, from nn to nn+ss. >>>>> >>>>> That is, exchange nn and ss. >>>> >>>> Yes, I understand that that's what you are reporting. I just haven't yet >>>> worked out how the code manages to exchange those 2 values. >>>> >>> >>> It doesn't, the documentation is correct as written and could be improved >>> by your suggestion of "Region of memory to be reserved, from ss to ss+nn." >>> I think Andiry probably is having a problem with his bootloader >>> interpreting the '$' incorrectly (or variable expansion if coming from the >>> shell) or interpreting the resulting user-defined e820 map incorrectly. >>> -- >> >> Yeah, I certainly don't see a problem with the code and I would want to >> see/understand that before I exchanged the 2 values in the documentation. >> >> I'll submit a patch to make the wording a bit better. >> > > I'm using Ubuntu 13.04 with GRUB2. If it's a bootloader issue, what should I do? See https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/448413 i.e., use shell escape '\' character. -- ~Randy -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org