From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACF79C6379F for ; Wed, 22 Feb 2023 09:05:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 228BB6B0071; Wed, 22 Feb 2023 04:05:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B2616B0073; Wed, 22 Feb 2023 04:05:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 004826B0074; Wed, 22 Feb 2023 04:05:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E19A96B0071 for ; Wed, 22 Feb 2023 04:05:26 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AC7851A0AFF for ; Wed, 22 Feb 2023 09:05:26 +0000 (UTC) X-FDA: 80494344252.28.808BB90 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 8D90BC0023 for ; Wed, 22 Feb 2023 09:05:24 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XR9b0fi9; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677056724; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9LjUQ9O0HnvcxKh2XAsUTz7YC8LaZ/FmXdZBrCkpK+Q=; b=MpZnGWsxqTlau31C0DvdlJ41Fcm9M9ec/d1IS0+LKXMMr9xNaHzv0fMZS7+uMC+Jc7z+oT 2tVe/fENd7PqtQk5yXDIVXIiHeyUQlMoibCUYdqzcTu6uUawMj7SD59Cu6nsny5g1PQD/l c2uiEIru/6C3FGb2NJur8LZUpcGXVJk= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XR9b0fi9; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677056724; a=rsa-sha256; cv=none; b=Dr+hkmXOObYYYozLMLT1+vLt9qWz1WihducK/Frl2e8n6wCw8r+rfKQ62N2lglu32d7xuf l8QZ/o80vO1gbDq5NmUiYInVzxz9GnV60qJX/AiLEvLnKFNpYOt7VmVcGtXfWtJ980U3AT Avg6og3iFss2Hp0mgDXD/tPJhT3wF7I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677056723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9LjUQ9O0HnvcxKh2XAsUTz7YC8LaZ/FmXdZBrCkpK+Q=; b=XR9b0fi9KvAiaDE5BTpc8TIOo/qeHDi/6bFhI2uNFW5uWGqpkfgvQAMrEKbV0W/KPpWkN3 9IniZuquw6W2gHT+DX86O89ZNADBkd0SalosCPceq+edugj7/xobyiZfJQ2Sqvkvshwhdb RzzLiGVMmu8xLawJ6umYmi7w8Q02jEQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-653-lRdaZjfwOleiHvaPxDZeyQ-1; Wed, 22 Feb 2023 04:05:22 -0500 X-MC-Unique: lRdaZjfwOleiHvaPxDZeyQ-1 Received: by mail-wr1-f71.google.com with SMTP id a7-20020a056000188700b002c53d342406so1394054wri.2 for ; Wed, 22 Feb 2023 01:05:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:organization:from :content-language:references:cc:to:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9LjUQ9O0HnvcxKh2XAsUTz7YC8LaZ/FmXdZBrCkpK+Q=; b=P930UiocnR8zbTK9ZqyPGFFSbpZXbBBYYRIpMoij0/aN38vBuMiFPJR43hhq4TPgxQ Om9ofXr6qoOS/E4JaYhD4LgUbge6nRvbdr/7tWLxW2xYO64bsr1az4E9MOvT16IE4plE P5+7fCWaKpCP+wMSiG6cU7a2EPjKMLOfewwXreq2eXoBvlh+vclaBLtl3dC/5CtqRn6v O15AECaTRmy9x3qymcPCh2aNM25PTYdxaii6Y6GyUWdh7Ti4ihjOs1RcE4V4gIj6y+pC CtIi1nOuh7+SU1pn/Z6PLzrGgi8ys9NUPG3MIYWbBAgOZd90a3MgfdkCv24PoIqFQiJA ayuA== X-Gm-Message-State: AO0yUKXFx3snXNVKMsW41gbW1Xh3JJv3HsJkviWld2mUZnexkRRFvizm EJESIQo4EJEcmb98uruU4rNLqe43Qj/HgN+eDkBh9iOcI+ZiAeHyqa5BIFR/UnUR6vqHiukTBgR H7zDVSXxHWK0= X-Received: by 2002:a05:600c:80f:b0:3db:fc3:6de4 with SMTP id k15-20020a05600c080f00b003db0fc36de4mr5069700wmp.35.1677056721236; Wed, 22 Feb 2023 01:05:21 -0800 (PST) X-Google-Smtp-Source: AK7set9SGBIryzMFukKmMVx5ow2JjCNOU/7I00r/woNcU3wsCpyUfsO529XXrVJjBQAVq81y0YSzRQ== X-Received: by 2002:a05:600c:80f:b0:3db:fc3:6de4 with SMTP id k15-20020a05600c080f00b003db0fc36de4mr5069668wmp.35.1677056720798; Wed, 22 Feb 2023 01:05:20 -0800 (PST) Received: from ?IPV6:2003:cb:c704:a100:95ad:6325:131:6b1d? (p200300cbc704a10095ad632501316b1d.dip0.t-ipconnect.de. [2003:cb:c704:a100:95ad:6325:131:6b1d]) by smtp.gmail.com with ESMTPSA id c22-20020a7bc856000000b003e01493b136sm7194166wml.43.2023.02.22.01.05.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Feb 2023 01:05:20 -0800 (PST) Message-ID: <52f001ef-a409-4f33-f28f-02e806ef305a@redhat.com> Date: Wed, 22 Feb 2023 10:05:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 To: Dave Hansen , "Edgecombe, Rick P" , "bsingharora@gmail.com" , "hpa@zytor.com" , "Syromiatnikov, Eugene" , "peterz@infradead.org" , "rdunlap@infradead.org" , "keescook@chromium.org" , "dave.hansen@linux.intel.com" , "kirill.shutemov@linux.intel.com" , "Eranian, Stephane" , "linux-mm@kvack.org" , "fweimer@redhat.com" , "nadav.amit@gmail.com" , "jannh@google.com" , "dethoma@microsoft.com" , "linux-arch@vger.kernel.org" , "kcc@google.com" , "pavel@ucw.cz" , "oleg@redhat.com" , "hjl.tools@gmail.com" , "bp@alien8.de" , "Lutomirski, Andy" , "linux-doc@vger.kernel.org" , "arnd@arndb.de" , "tglx@linutronix.de" , "Schimpe, Christina" , "x86@kernel.org" , "mike.kravetz@oracle.com" , "Yang, Weijiang" , "debug@rivosinc.com" , "jamorris@linux.microsoft.com" , "john.allen@amd.com" , "rppt@kernel.org" , "andrew.cooper3@citrix.com" , "mingo@redhat.com" , "corbet@lwn.net" , "linux-kernel@vger.kernel.org" , "linux-api@vger.kernel.org" , "gorcunov@gmail.com" , "akpm@linux-foundation.org" Cc: "Yu, Yu-cheng" References: <20230218211433.26859-1-rick.p.edgecombe@intel.com> <20230218211433.26859-15-rick.p.edgecombe@intel.com> <70681787-0d33-a9ed-7f2a-747be1490932@redhat.com> <6f19d7c7ad9f61fa8f6c9bd09d24524dbe17463f.camel@intel.com> <6e1201f5-da25-6040-8230-c84856221838@redhat.com> <273414f5-2a7c-3cc0-dc27-d07baaa5787b@intel.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v6 14/41] x86/mm: Introduce _PAGE_SAVED_DIRTY In-Reply-To: <273414f5-2a7c-3cc0-dc27-d07baaa5787b@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8D90BC0023 X-Stat-Signature: 91bgy9jcbiyrdeopyjk817s6uaiyekwn X-HE-Tag: 1677056724-659322 X-HE-Meta: U2FsdGVkX1/sxs4Xb5BSD8GLDk6V3fx3sAFbmIlYLNZlOhccICGS4D8cJ+TNP7uFtbu8QEm0jXHH5KkAQlwltqlmt6MqM/fyz7FZG081lX93sW/M+hcuyDN5SVRAxc8l4cUIISLIPX1wlsG5GwvJDs9ubq1P5bTZ4KYzoZQnf8JDPNIxW1VBY2i3k/T65Nzq5crSk3leDHVJOoEbN5UrBfRUFe9kfTwdsMVj03txs9iKtMvmYf3X78HFsFtfVwV8GxcTQKtY/wONY225FDlnKUpoh6t+5nHewgPIvHLI6xIG3yrE1ylaGtUKUvT/U9i2K5s6h7S7FNwwXiBFCU/o52Y6jlM8pSjcDOd4nNmYKUyFGTptRKYUSr+z7cRPiQs5M4vhIoztPTxGs83YkFN4B1eKHL4m9z7V3Z6LAplPN4khDAWAFjFcrouX2edCWJ51bHdX5H04opisG0Lo61VuiFrEhwOVHRsfQQnJyDKi3xLNYHKM5wryqtkGhw7RNbOqYijhoPjLhiQna6WdApY5H98nS3rxG1O8hZBg8VsF1W/iNMCTdjg9xAlVkMXqgavWUMBHjIs6ohdZPrMBXVO4RdAP4ivJLTmm2MNN4SSld9vgp6UKzN4TzkxEBmxZYrzLxWYc1t+PGCUPBU+Fh4uIw3AaN+YdCYbWRFHxBCRdq0XWsYs+CmJw08QXoX3Jwt9N4CzCrcpwsmlX+MsegGd0Q0V609l2VvlK3bVwb8zJP3nsVtCGES2vrVJynGXQi7x1glalYf+HeL+zO4qUTZQtwcajWXwgfl4ndruDG2YynW+8uYqglsAoI4n4Tyy4KK8kX/c2M9Apd1WFqE1O8fdxIRiw3hOoteXmsUcKRfglSofqpll39A54XpYIemzze/8pWLQ3DHBd2gjgr5SD3qPelbNgtYawuQWAnjAarBbf/4Bq1sc7uv9EnftPUYCDRlxJ4nO91fcQTy9tGzaY6EV ETqhtwfb NCV37e9gwRiEPhZIcfvhZhwjWlsv9qbPv3EtsmO2qFdEJIANftr3feIuK7ZJdCJSTKsWjqXq/hsbcVjG09Oq27Pbq2NEBErz5EQe/C7MRT7iFARliRlZmh/sWgPOi1KQXQPma+pg/WYpW8OWg3cq8GQr/nZ0Dp+G/WkT900L5Ss/Im71bxlq6U+0fADhZFJ+Nj5LnMV7JJGY5z+xAQOhuiOEB+taIkNadrHUxDP4S3SC2ADM3V/LsHVjn+TRf6rmWT4jJomHnRrpeunQ54oLxYNamJd+20RysjVDrAavxnC5XpXHDsZL/MFBCqOrEdkYyWKDv9IrD3a4ri7uTkfWU9iKeXE7AyRVL3Xj8vxqXF2/pQu840ITucKvkl9+7/1kD7UqvwIoBPxlLyIs6FMd8c2Bwju3Ptsx6/PfQ9zEfRFpNCtGSRgIt0tswFLZSDIjjV2pBoX2ERajhLpXQ/OUX3OmoQw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21.02.23 21:13, Dave Hansen wrote: > On 2/21/23 00:38, David Hildenbrand wrote:> Sure, for my taste this is > (1) too repetitive (2) too verbose (3) to >> specialized. But whatever x86 maintainers prefer. > > At this point, I'm not going to be too nitpicky. I personally think we > need to get _something_ merged. We can then nitpick it to death once > its in the tree. Yes, but ... do we have to rush right now? This series wasn't in -next and we're in the merge window. Is the plan to still include it into this merge window? Also, I think concise patch descriptions and comments are not necessarily nitpicking like "please rename that variable". > > So I prefer whatever will move the set along. ;) If the plan is to merge it in the next merge window (which I suspect, but I might be wrong), I suggest including it in -next fairly soonish, and in the meantime, polish the remaining bits. Knowing the plan would be good ;) -- Thanks, David / dhildenb