From: Rik van Riel <riel@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
linux-mm@kvack.org, peterz@infradead.org, chegu_vinod@hp.com,
aarcange@redhat.com, akpm@linux-foundation.org
Subject: Re: [PATCH -mm 3/3] move mmu notifier call from change_protection to change_pmd_range
Date: Tue, 18 Feb 2014 22:08:27 -0500 [thread overview]
Message-ID: <5304202B.20203@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1402181823420.20791@chino.kir.corp.google.com>
On 02/18/2014 09:24 PM, David Rientjes wrote:
> On Tue, 18 Feb 2014, riel@redhat.com wrote:
>
>> From: Rik van Riel <riel@redhat.com>
>>
>> The NUMA scanning code can end up iterating over many gigabytes
>> of unpopulated memory, especially in the case of a freshly started
>> KVM guest with lots of memory.
>>
>> This results in the mmu notifier code being called even when
>> there are no mapped pages in a virtual address range. The amount
>> of time wasted can be enough to trigger soft lockup warnings
>> with very large KVM guests.
>>
>> This patch moves the mmu notifier call to the pmd level, which
>> represents 1GB areas of memory on x86-64. Furthermore, the mmu
>> notifier code is only called from the address in the PMD where
>> present mappings are first encountered.
>>
>> The hugetlbfs code is left alone for now; hugetlb mappings are
>> not relocatable, and as such are left alone by the NUMA code,
>> and should never trigger this problem to begin with.
>>
>> Signed-off-by: Rik van Riel <riel@redhat.com>
>> Cc: Peter Zijlstra <peterz@infradead.org>
>> Cc: Andrea Arcangeli <aarcange@redhat.com>
>> Reported-by: Xing Gang <gang.xing@hp.com>
>> Tested-by: Chegu Vinod <chegu_vinod@hp.com>
>
> Acked-by: David Rientjes <rientjes@google.com>
>
> Might have been cleaner to move the
> mmu_notifier_invalidate_range_{start,end}() to hugetlb_change_protection()
> as well, though.
I can certainly do that if you want. Just let me know
and I'll send a v2 of patch 3 :)
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-02-19 3:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 22:12 [PATCH -mm 0/3] fix numa vs kvm scalability issue riel
2014-02-18 22:12 ` [PATCH -mm 1/3] sched,numa: add cond_resched to task_numa_work riel
2014-02-18 22:12 ` [PATCH -mm 2/3] mm,numa: reorganize change_pmd_range riel
2014-02-19 2:22 ` David Rientjes
2014-02-18 22:12 ` [PATCH -mm 3/3] move mmu notifier call from change_protection to change_pmd_range riel
2014-02-19 2:24 ` David Rientjes
2014-02-19 3:08 ` Rik van Riel [this message]
2014-02-19 3:18 ` [PATCH -mm v2 " Rik van Riel
2014-02-19 8:59 ` [PATCH -mm 0/3] fix numa vs kvm scalability issue Peter Zijlstra
2014-02-19 19:28 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5304202B.20203@redhat.com \
--to=riel@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=chegu_vinod@hp.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).