From: Sasha Levin <sasha.levin@oracle.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH] mm: add pte_present() check on existing hugetlb_entry callbacks
Date: Mon, 03 Mar 2014 15:06:37 -0500 [thread overview]
Message-ID: <5314E0CD.6070308@oracle.com> (raw)
In-Reply-To: <1393822946-26871-1-git-send-email-n-horiguchi@ah.jp.nec.com>
On 03/03/2014 12:02 AM, Naoya Horiguchi wrote:
> Hi Sasha,
>
>> >I can confirm that with this patch the lockdep issue is gone. However, the NULL deref in
>> >walk_pte_range() and the BUG at mm/hugemem.c:3580 still appear.
> I spotted the cause of this problem.
> Could you try testing if this patch fixes it?
I'm seeing a different failure with this patch:
[ 1860.669114] BUG: unable to handle kernel NULL pointer dereference at 0000000000000050
[ 1860.670498] IP: [<ffffffff8129c0bf>] vm_normal_page+0x3f/0x90
[ 1860.672795] PGD 6c1c84067 PUD 6e0a3d067 PMD 0
[ 1860.672795] Oops: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC
[ 1860.672795] Dumping ftrace buffer:
[ 1860.672795] (ftrace buffer empty)
[ 1860.672795] Modules linked in:
[ 1860.672795] CPU: 4 PID: 34914 Comm: trinity-c184 Tainted: G W 3.14.0-rc4-ne
[ 1860.672795] task: ffff880717d90000 ti: ffff88070b3da000 task.ti: ffff88070b3da000
[ 1860.672795] RIP: 0010:[<ffffffff8129c0bf>] [<ffffffff8129c0bf>] vm_normal_page+0x3f/
[ 1860.672795] RSP: 0018:ffff88070b3dbba8 EFLAGS: 00010202
[ 1860.672795] RAX: 000000000000767f RBX: ffff88070b3dbdd8 RCX: ffff88070b3dbd78
[ 1860.672795] RDX: 800000000767f225 RSI: 0100000000699000 RDI: 800000000767f225
[ 1860.672795] RBP: ffff88070b3dbba8 R08: 0000000000000000 R09: 0000000000000000
[ 1860.672795] R10: 0000000000000001 R11: 0000000000000000 R12: ffff880717df24c8
[ 1860.672795] R13: 0000000000000020 R14: 0100000000699000 R15: 0100000000800000
[ 1860.672795] FS: 00007f20a3584700(0000) GS:ffff88052b800000(0000) knlGS:0000000000000
[ 1860.672795] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 1860.672795] CR2: 0000000000000050 CR3: 00000006d73cf000 CR4: 00000000000006e0
[ 1860.672795] Stack:
[ 1860.672795] ffff88070b3dbbd8 ffffffff812c2f3d ffffffff812b2dc0 010000000069a000
[ 1860.672795] ffff880717df24c8 ffff88070b3dbd78 ffff88070b3dbc28 ffffffff812b2e00
[ 1860.672795] 0000000000000000 ffff88072956bcf0 ffff88070b3dbc28 ffff8806e0a3d018
[ 1860.672795] Call Trace:
[ 1860.672795] [<ffffffff812c2f3d>] queue_pages_pte+0x3d/0xd0
[ 1860.672795] [<ffffffff812b2dc0>] ? walk_pte_range+0xc0/0x180
[ 1860.672795] [<ffffffff812b2e00>] walk_pte_range+0x100/0x180
[ 1860.672795] [<ffffffff812b3091>] walk_pmd_range+0x211/0x240
[ 1860.672795] [<ffffffff812b31eb>] walk_pud_range+0x12b/0x160
[ 1860.672795] [<ffffffff812d2ee4>] ? __slab_free+0x384/0x5e0
[ 1860.672795] [<ffffffff812b3329>] walk_pgd_range+0x109/0x140
[ 1860.672795] [<ffffffff812b3395>] __walk_page_range+0x35/0x40
[ 1860.672795] [<ffffffff812b3552>] walk_page_range+0xf2/0x130
[ 1860.672795] [<ffffffff812c2e41>] queue_pages_range+0x71/0x90
[ 1860.672795] [<ffffffff812c2f00>] ? queue_pages_hugetlb+0xa0/0xa0
[ 1860.672795] [<ffffffff812c2e60>] ? queue_pages_range+0x90/0x90
[ 1860.672795] [<ffffffff812c30d0>] ? change_prot_numa+0x30/0x30
[ 1860.672795] [<ffffffff812c6c61>] do_mbind+0x321/0x340
[ 1860.672795] [<ffffffff8129af2f>] ? might_fault+0x9f/0xb0
[ 1860.672795] [<ffffffff8129aee6>] ? might_fault+0x56/0xb0
[ 1860.672795] [<ffffffff812c6d09>] SYSC_mbind+0x89/0xb0
[ 1860.672795] [<ffffffff81268db5>] ? context_tracking_user_exit+0x195/0x1d0
[ 1860.672795] [<ffffffff812c6d3e>] SyS_mbind+0xe/0x10
[ 1860.672795] [<ffffffff8447d890>] tracesys+0xdd/0xe2
Thanks,
Sasha
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-03-03 20:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 4:39 [PATCH 0/3] fixes on page table walker and hugepage rmapping Naoya Horiguchi
2014-02-27 4:39 ` [PATCH 1/3] mm/pagewalk.c: fix end address calculation in walk_page_range() Naoya Horiguchi
2014-02-27 21:03 ` Andrew Morton
2014-02-27 21:19 ` Naoya Horiguchi
2014-02-27 21:20 ` Kirill A. Shutemov
2014-02-27 21:54 ` Naoya Horiguchi
2014-02-27 4:39 ` [PATCH 2/3] mm, hugetlbfs: fix rmapping for anonymous hugepages with page_pgoff() Naoya Horiguchi
2014-02-27 21:19 ` Andrew Morton
2014-02-27 21:53 ` Naoya Horiguchi
2014-02-28 19:59 ` [PATCH v2] " Naoya Horiguchi
[not found] ` <5310ea8b.c425e00a.2cd9.ffffe097SMTPIN_ADDED_BROKEN@mx.google.com>
2014-02-28 23:14 ` Andrew Morton
2014-03-01 3:35 ` [PATCH v3] " Naoya Horiguchi
[not found] ` <1393644926-49vw3qw9@n-horiguchi@ah.jp.nec.com>
2014-03-01 23:08 ` Sasha Levin
2014-03-03 5:02 ` [PATCH] mm: add pte_present() check on existing hugetlb_entry callbacks Naoya Horiguchi
2014-03-03 20:06 ` Sasha Levin [this message]
2014-03-03 21:38 ` Sasha Levin
2014-03-04 21:32 ` Naoya Horiguchi
[not found] ` <1393968743-imrxpynb@n-horiguchi@ah.jp.nec.com>
2014-03-04 22:46 ` Sasha Levin
2014-03-04 23:49 ` Naoya Horiguchi
[not found] ` <1393976967-lnmm5xcs@n-horiguchi@ah.jp.nec.com>
2014-03-06 4:31 ` Sasha Levin
2014-03-06 16:08 ` Naoya Horiguchi
[not found] ` <1394122113-xsq3i6vw@n-horiguchi@ah.jp.nec.com>
2014-03-06 21:16 ` Sasha Levin
2014-03-07 6:35 ` Naoya Horiguchi
2014-03-15 6:45 ` Naoya Horiguchi
2014-02-27 4:39 ` [PATCH 3/3] mm: call vma_adjust_trans_huge() only for thp-enabled vma Naoya Horiguchi
2014-02-27 21:23 ` Andrew Morton
2014-02-27 22:08 ` Naoya Horiguchi
2014-02-27 22:56 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5314E0CD.6070308@oracle.com \
--to=sasha.levin@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).