From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qa0-f48.google.com (mail-qa0-f48.google.com [209.85.216.48]) by kanga.kvack.org (Postfix) with ESMTP id 2AB4C6B0031 for ; Fri, 7 Mar 2014 08:06:46 -0500 (EST) Received: by mail-qa0-f48.google.com with SMTP id m5so3946404qaj.35 for ; Fri, 07 Mar 2014 05:06:45 -0800 (PST) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTP id 61si1743769qgw.61.2014.03.07.05.06.45 for ; Fri, 07 Mar 2014 05:06:45 -0800 (PST) Message-ID: <5319BB3A.6020102@redhat.com> Date: Fri, 07 Mar 2014 07:27:38 -0500 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [patch] mm, compaction: determine isolation mode only once References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: David Rientjes , Andrew Morton Cc: Mel Gorman , Vlastimil Babka , Joonsoo Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org On 03/07/2014 07:01 AM, David Rientjes wrote: > The conditions that control the isolation mode in > isolate_migratepages_range() do not change during the iteration, so > extract them out and only define the value once. > > This actually does have an effect, gcc doesn't optimize it itself because > of cc->sync. > > Signed-off-by: David Rientjes Acked-by: Rik van Riel -- All rights reversed -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org