From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f169.google.com (mail-ob0-f169.google.com [209.85.214.169]) by kanga.kvack.org (Postfix) with ESMTP id 458236B00AA for ; Tue, 11 Mar 2014 12:59:41 -0400 (EDT) Received: by mail-ob0-f169.google.com with SMTP id va2so8688183obc.14 for ; Tue, 11 Mar 2014 09:59:40 -0700 (PDT) Received: from aserp1040.oracle.com (aserp1040.oracle.com. [141.146.126.69]) by mx.google.com with ESMTPS id e6si21888996oen.101.2014.03.11.09.59.40 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 11 Mar 2014 09:59:40 -0700 (PDT) Message-ID: <531F3F15.8050206@oracle.com> Date: Tue, 11 Mar 2014 12:51:33 -0400 From: Sasha Levin MIME-Version: 1.0 Subject: Re: [PATCH -mm] mm,numa,mprotect: always continue after finding a stable thp page References: <5318E4BC.50301@oracle.com> <20140306173137.6a23a0b2@cuia.bos.redhat.com> <5318FC3F.4080204@redhat.com> <20140307140650.GA1931@suse.de> <20140307150923.GB1931@suse.de> <20140307182745.GD1931@suse.de> <20140311162845.GA30604@suse.de> In-Reply-To: <20140311162845.GA30604@suse.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Mel Gorman , Rik van Riel Cc: David Rientjes , Andrew Morton , "linux-mm@kvack.org" , LKML , hhuang@redhat.com, knoel@redhat.com, aarcange@redhat.com On 03/11/2014 12:28 PM, Mel Gorman wrote: > On Fri, Mar 07, 2014 at 06:27:45PM +0000, Mel Gorman wrote: >>> This is a completely untested prototype. It rechecks pmd_trans_huge >>> under the lock and falls through if it hit a parallel split. It's not >>> perfect because it could decide to fall through just because there was >>> no prot_numa work to do but it's for illustration purposes. Secondly, >>> I noted that you are calling invalidate for every pmd range. Is that not >>> a lot of invalidations? We could do the same by just tracking the address >>> of the first invalidation. >>> >> >> And there were other minor issues. This is still untested but Sasha, >> can you try it out please? I discussed this with Rik on IRC for a bit and >> reckon this should be sufficient if the correct race has been identified. >> > > Any luck with this patch Sasha? It passed basic tests here but I had not > seen the issue trigger either. > Sorry, I've been stuck in my weekend project of getting lockdep to work with page locks :) It takes a moment to test, so just to be sure - I should have only this last patch applied? Without the one in the original mail? Thanks, Sasha -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org