From: "Michael Rubin" <mrubin@google.com>
To: Fengguang Wu <wfg@mail.ustc.edu.cn>
Cc: a.p.zijlstra@chello.nl, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Chris Mason <chris.mason@oracle.com>
Subject: Re: [patch 1/1] Writeback fix for concurrent large and small file writes
Date: Thu, 29 Nov 2007 12:16:36 -0800 [thread overview]
Message-ID: <532480950711291216l181b0bej17db6c42067aa832@mail.gmail.com> (raw)
In-Reply-To: <396296481.07368@ustc.edu.cn>
Due to my faux pas of top posting (see
http://www.zip.com.au/~akpm/linux/patches/stuff/top-posting.txt) I am
resending this email.
On Nov 28, 2007 4:34 PM, Fengguang Wu <wfg@mail.ustc.edu.cn> wrote:
> Could you demonstrate the situation? Or if I guess it right, could it
> be fixed by the following patch? (not a nack: If so, your patch could
> also be considered as a general purpose improvement, instead of a bug
> fix.)
>
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index 0fca820..62e62e2 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -301,7 +301,7 @@ __sync_single_inode(struct inode *inode, struct writeback_control *wbc)
> * Someone redirtied the inode while were writing back
> * the pages.
> */
> - redirty_tail(inode);
> + requeue_io(inode);
> } else if (atomic_read(&inode->i_count)) {
> /*
> * The inode is clean, inuse
>
By testing the situation I can confirm that the one line patch above
fixes the problem.
I will continue testing some other cases to see if it cause any other
issues but I don't expect it to.
I will post this change for 2.6.24 and list Feng as author. If that's
ok with Feng.
As for the original patch I will resubmit it for 2.6.25 as a general
purpose improvement.
mrubin
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-11-29 20:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-28 19:29 [patch 1/1] Writeback fix for concurrent large and small file writes Michael Rubin
[not found] ` <E1IxXMP-0002i8-4S@localhost>
2007-11-29 0:34 ` Fengguang Wu
2007-11-29 19:51 ` Michael Rubin
2007-11-29 20:16 ` Michael Rubin [this message]
[not found] ` <E1IxukV-0003Ns-5C@localhost>
2007-11-30 1:32 ` Fengguang Wu
2007-12-04 9:06 ` Michael Rubin
2007-11-29 2:13 ` Frans Pop
2007-11-29 6:58 ` Michael Rubin
-- strict thread matches above, loose matches on Subject: below --
2007-12-11 2:02 Michael Rubin, Michael Rubin
2007-12-12 20:55 ` Peter Zijlstra
2007-12-12 23:03 ` Michael Rubin
[not found] ` <E1J89kR-0001v3-CJ@localhost>
2007-12-28 7:35 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532480950711291216l181b0bej17db6c42067aa832@mail.gmail.com \
--to=mrubin@google.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=chris.mason@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wfg@mail.ustc.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).