Re: [PATCH] mm: remove BUG_ON() from mlock_vma_page()

[Bob Liu <bob.liu@oracle.com>]

On 03/12/2014 02:43 AM, Dave Jones wrote:
> On Mon, Mar 03, 2014 at 05:12:25PM +0100, Vlastimil Babka wrote:
> 
>  > >> On 01/31/2014 03:33 PM, Andrew Morton wrote:
>  > >>> On Wed, 18 Dec 2013 08:42:49 +0800 Bob Liu<lliubbo@gmail.com>  wrote:
>  > >>>
>  > >>>>> This BUG_ON() was triggered when called from try_to_unmap_cluster()
>  > >>>>> which didn't lock the page.
>  > >>>>> And it's safe to mlock_vma_page() without PageLocked, so this patch
>  > >>>>> fix this issue by removing that BUG_ON() simply.
>  > >>>>>
>  > >>> This patch doesn't appear to be going anywhere, so I will drop it.
>  > >>> Please let's check to see whether the bug still exists and if so,
>  > >>> start another round of bugfixing.
>  > >>
>  > >> This bug still happens on the latest -next kernel.
>  > >
>  > > Yeah, I recognized it. I'm preparing new patch. Thanks.
>  > 
>  > What will be your approach? After we had the discussion some month ago 
>  > about m(un)lock vs migration I've concluded that there is no race that 
>  > page lock helps, and removing the BUG_ON() would be indeed correct. Just 
>  > needs to be correctly explained and documentation updated as well.
> 
> This is not just a -next problem btw, I just hit this in 3.14-rc6
> 

It seems the fix patch from Vlastimil was missed, I've resend it to Andrew.

-- 
Regards,
-Bob

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>