From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yh0-f42.google.com (mail-yh0-f42.google.com [209.85.213.42]) by kanga.kvack.org (Postfix) with ESMTP id 124246B0283 for ; Fri, 21 Mar 2014 18:37:19 -0400 (EDT) Received: by mail-yh0-f42.google.com with SMTP id t59so3068836yho.15 for ; Fri, 21 Mar 2014 15:37:18 -0700 (PDT) Received: from aserp1040.oracle.com (aserp1040.oracle.com. [141.146.126.69]) by mx.google.com with ESMTPS id y29si7548942yhg.113.2014.03.21.15.37.18 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 21 Mar 2014 15:37:18 -0700 (PDT) Message-ID: <532CBF08.4030100@oracle.com> Date: Fri, 21 Mar 2014 18:36:56 -0400 From: Sasha Levin MIME-Version: 1.0 Subject: Re: [PATCH] mm: numa: Recheck for transhuge pages under lock during protection changes References: <20140307182745.GD1931@suse.de> <20140311162845.GA30604@suse.de> <531F3F15.8050206@oracle.com> <531F4128.8020109@redhat.com> <531F48CC.303@oracle.com> <20140311180652.GM10663@suse.de> <531F616A.7060300@oracle.com> <20140311122859.fb6c1e772d82d9f4edd02f52@linux-foundation.org> <20140312103602.GN10663@suse.de> <5323C5D9.2070902@oracle.com> <20140319143831.GA4751@suse.de> <20140321150658.386926ac3afa263946b1a2aa@linux-foundation.org> In-Reply-To: <20140321150658.386926ac3afa263946b1a2aa@linux-foundation.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton , Mel Gorman Cc: Rik van Riel , David Rientjes , hhuang@redhat.com, knoel@redhat.com, aarcange@redhat.com, Davidlohr Bueso , "linux-mm@kvack.org" , LKML On 03/21/2014 06:06 PM, Andrew Morton wrote: > On Wed, 19 Mar 2014 14:38:32 +0000 Mel Gorman wrote: > >> >On Fri, Mar 14, 2014 at 11:15:37PM -0400, Sasha Levin wrote: >>> > >On 03/12/2014 06:36 AM, Mel Gorman wrote: >>>> > > >Andrew, this should go with the patches >>>> > > >mmnuma-reorganize-change_pmd_range.patch >>>> > > >mmnuma-reorganize-change_pmd_range-fix.patch >>>> > > >move-mmu-notifier-call-from-change_protection-to-change_pmd_range.patch >>>> > > >in mmotm please. >>>> > > > >>>> > > >Thanks. >>>> > > > >>>> > > >---8<--- >>>> > > >From: Mel Gorman >>>> > > >Subject: [PATCH] mm: numa: Recheck for transhuge pages under lock during protection changes >>>> > > > >>>> > > >Sasha Levin reported the following bug using trinity >>> > > >>> > >I'm seeing a different issue with this patch. A NULL ptr deref occurs in the >>> > >pte_offset_map_lock() macro right before the new recheck code: >>> > > >> > >> >This on top? >> > >> >I tried testing it but got all sorts of carnage that trinity throw up >> >in the mix and ordinary testing does not trigger the race. I've no idea >> >which of the current mess of trinity-exposed bugs you've encountered and >> >got fixed already. >> > > Where are we at with this one? Looking good here, haven't seen any of the issues reported in this thread. Thanks, Sasha -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org