From: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
To: Rusty Russell <rusty@rustcorp.com.au>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-mm@kvack.org, linux-arch@vger.kernel.org, x86@kernel.org
Cc: benh@kernel.crashing.org, paulus@samba.org,
kirill.shutemov@linux.intel.com, akpm@linux-foundation.org,
riel@redhat.com, mgorman@suse.de, ak@linux.intel.com,
peterz@infradead.org, mingo@kernel.org, dave.hansen@intel.com
Subject: Re: [PATCH V3 2/2] powerpc/pseries: init fault_around_order for pseries
Date: Tue, 29 Apr 2014 15:06:53 +0530 [thread overview]
Message-ID: <535F72B5.3000405@linux.vnet.ibm.com> (raw)
In-Reply-To: <877g686fpb.fsf@rustcorp.com.au>
On Tuesday 29 April 2014 07:48 AM, Rusty Russell wrote:
> Madhavan Srinivasan <maddy@linux.vnet.ibm.com> writes:
>> diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c
>> index 2db8cc6..c87e6b6 100644
>> --- a/arch/powerpc/platforms/pseries/setup.c
>> +++ b/arch/powerpc/platforms/pseries/setup.c
>> @@ -74,6 +74,8 @@ int CMO_SecPSP = -1;
>> unsigned long CMO_PageSize = (ASM_CONST(1) << IOMMU_PAGE_SHIFT_4K);
>> EXPORT_SYMBOL(CMO_PageSize);
>>
>> +extern unsigned int fault_around_order;
>> +
>
> It's considered bad form to do this. Put the declaration in linux/mm.h.
>
ok. Will change it.
Thanks for review
With regards
Maddy
> Thanks,
> Rusty.
> PS. But we're getting there! :)
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-04-29 9:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 9:01 [PATCH V3 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc Madhavan Srinivasan
2014-04-28 9:01 ` [PATCH V3 1/2] mm: move FAULT_AROUND_ORDER to arch/ Madhavan Srinivasan
2014-04-28 9:06 ` Peter Zijlstra
2014-04-29 9:33 ` Madhavan Srinivasan
2014-04-28 9:36 ` Kirill A. Shutemov
2014-04-29 9:35 ` Madhavan Srinivasan
2014-04-28 9:01 ` [PATCH V3 2/2] powerpc/pseries: init fault_around_order for pseries Madhavan Srinivasan
2014-04-29 2:18 ` Rusty Russell
2014-04-29 9:36 ` Madhavan Srinivasan [this message]
2014-04-29 7:06 ` Ingo Molnar
2014-04-29 10:35 ` Madhavan Srinivasan
2014-04-30 7:04 ` Rusty Russell
2014-04-30 8:15 ` Madhavan Srinivasan
2014-05-06 11:29 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535F72B5.3000405@linux.vnet.ibm.com \
--to=maddy@linux.vnet.ibm.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=dave.hansen@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).