From: Sasha Levin <sasha.levin@oracle.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 6/6] mm: Postpone the disabling of kmemleak early logging
Date: Tue, 06 May 2014 14:15:57 -0400 [thread overview]
Message-ID: <536926DD.30402@oracle.com> (raw)
In-Reply-To: <20140506170549.GM23957@arm.com>
On 05/06/2014 01:05 PM, Catalin Marinas wrote:
> On Tue, May 06, 2014 at 04:20:27PM +0100, Sasha Levin wrote:
>> On 05/02/2014 09:41 AM, Catalin Marinas wrote:
>>> Currently, kmemleak_early_log is disabled at the beginning of the
>>> kmemleak_init() function, before the full kmemleak tracing is actually
>>> enabled. In this small window, kmem_cache_create() is called by kmemleak
>>> which triggers additional memory allocation that are not traced. This
>>> patch moves the kmemleak_early_log disabling further down and at the
>>> same time with full kmemleak enabling.
>>>
>>> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
>>> Cc: Andrew Morton <akpm@linux-foundation.org>
>>
>> This patch makes the kernel die during the boot process:
>>
>> [ 24.471801] BUG: unable to handle kernel paging request at ffffffff922f2b93
>> [ 24.472496] IP: [<ffffffff922f2b93>] log_early+0x0/0xcd
>
> Thanks for reporting this. I assume you run with
> CONFIG_DEBUG_KMEMLEAK_DEFAULT_OFF enabled and kmemleak_early_log remains
> set even though kmemleak is not in use.
>
> Does the patch below fix it?
Nope, that didn't help as I don't have DEBUG_KMEMLEAK_DEFAULT_OFF enabled.
For reference:
$ cat .config | grep KMEMLEAK
CONFIG_HAVE_DEBUG_KMEMLEAK=y
CONFIG_DEBUG_KMEMLEAK=y
CONFIG_DEBUG_KMEMLEAK_EARLY_LOG_SIZE=400
# CONFIG_DEBUG_KMEMLEAK_TEST is not set
# CONFIG_DEBUG_KMEMLEAK_DEFAULT_OFF is not set
Thanks,
Sasha
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-05-06 18:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-02 13:41 [PATCH 0/6] Kmemleak updates Catalin Marinas
2014-05-02 13:41 ` [PATCH 1/6] mm/kmemleak.c: Use %u to print ->checksum Catalin Marinas
2014-05-02 13:41 ` [PATCH 2/6] mm: Introduce kmemleak_update_trace() Catalin Marinas
2014-05-02 13:41 ` [PATCH 3/6] lib: Update the kmemleak stack trace for radix tree allocations Catalin Marinas
2014-05-02 13:48 ` Johannes Weiner
2014-05-02 13:41 ` [PATCH 4/6] mm: Update the kmemleak stack trace for mempool allocations Catalin Marinas
2014-05-02 13:41 ` [PATCH 5/6] mm: Call kmemleak directly from memblock_(alloc|free) Catalin Marinas
2014-05-02 13:41 ` [PATCH 6/6] mm: Postpone the disabling of kmemleak early logging Catalin Marinas
2014-05-06 15:20 ` Sasha Levin
2014-05-06 17:05 ` Catalin Marinas
2014-05-06 18:15 ` Sasha Levin [this message]
2014-05-06 21:52 ` Catalin Marinas
2014-05-06 23:08 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536926DD.30402@oracle.com \
--to=sasha.levin@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).