From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ie0-f179.google.com (mail-ie0-f179.google.com [209.85.223.179]) by kanga.kvack.org (Postfix) with ESMTP id 32C696B0071 for ; Tue, 6 May 2014 14:16:09 -0400 (EDT) Received: by mail-ie0-f179.google.com with SMTP id lx4so10242693iec.38 for ; Tue, 06 May 2014 11:16:08 -0700 (PDT) Received: from aserp1040.oracle.com (aserp1040.oracle.com. [141.146.126.69]) by mx.google.com with ESMTPS id d19si20397771igz.8.2014.05.06.11.16.08 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 06 May 2014 11:16:08 -0700 (PDT) Message-ID: <536926DD.30402@oracle.com> Date: Tue, 06 May 2014 14:15:57 -0400 From: Sasha Levin MIME-Version: 1.0 Subject: Re: [PATCH 6/6] mm: Postpone the disabling of kmemleak early logging References: <1399038070-1540-1-git-send-email-catalin.marinas@arm.com> <1399038070-1540-7-git-send-email-catalin.marinas@arm.com> <5368FDBB.8070106@oracle.com> <20140506170549.GM23957@arm.com> In-Reply-To: <20140506170549.GM23957@arm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Catalin Marinas Cc: "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Andrew Morton On 05/06/2014 01:05 PM, Catalin Marinas wrote: > On Tue, May 06, 2014 at 04:20:27PM +0100, Sasha Levin wrote: >> On 05/02/2014 09:41 AM, Catalin Marinas wrote: >>> Currently, kmemleak_early_log is disabled at the beginning of the >>> kmemleak_init() function, before the full kmemleak tracing is actually >>> enabled. In this small window, kmem_cache_create() is called by kmemleak >>> which triggers additional memory allocation that are not traced. This >>> patch moves the kmemleak_early_log disabling further down and at the >>> same time with full kmemleak enabling. >>> >>> Signed-off-by: Catalin Marinas >>> Cc: Andrew Morton >> >> This patch makes the kernel die during the boot process: >> >> [ 24.471801] BUG: unable to handle kernel paging request at ffffffff922f2b93 >> [ 24.472496] IP: [] log_early+0x0/0xcd > > Thanks for reporting this. I assume you run with > CONFIG_DEBUG_KMEMLEAK_DEFAULT_OFF enabled and kmemleak_early_log remains > set even though kmemleak is not in use. > > Does the patch below fix it? Nope, that didn't help as I don't have DEBUG_KMEMLEAK_DEFAULT_OFF enabled. For reference: $ cat .config | grep KMEMLEAK CONFIG_HAVE_DEBUG_KMEMLEAK=y CONFIG_DEBUG_KMEMLEAK=y CONFIG_DEBUG_KMEMLEAK_EARLY_LOG_SIZE=400 # CONFIG_DEBUG_KMEMLEAK_TEST is not set # CONFIG_DEBUG_KMEMLEAK_DEFAULT_OFF is not set Thanks, Sasha -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org