From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f178.google.com (mail-ig0-f178.google.com [209.85.213.178]) by kanga.kvack.org (Postfix) with ESMTP id 08F906B0031 for ; Tue, 3 Jun 2014 21:38:45 -0400 (EDT) Received: by mail-ig0-f178.google.com with SMTP id h18so475030igc.17 for ; Tue, 03 Jun 2014 18:38:44 -0700 (PDT) Received: from aserp1040.oracle.com (aserp1040.oracle.com. [141.146.126.69]) by mx.google.com with ESMTPS id el8si1848707icc.14.2014.06.03.18.38.44 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 03 Jun 2014 18:38:44 -0700 (PDT) Message-ID: <538E7890.3020600@oracle.com> Date: Wed, 04 Jun 2014 09:38:24 +0800 From: Bob Liu MIME-Version: 1.0 Subject: Re: [PATCHv4 0/6] mm/zpool: add common api for zswap to use zbud/zsmalloc References: <1400958369-3588-1-git-send-email-ddstreet@ieee.org> <1401747586-11861-1-git-send-email-ddstreet@ieee.org> In-Reply-To: <1401747586-11861-1-git-send-email-ddstreet@ieee.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Dan Streetman Cc: Seth Jennings , Minchan Kim , Weijie Yang , Nitin Gupta , Andrew Morton , Hugh Dickins , Mel Gorman , Rik van Riel , Johannes Weiner , Sergey Senozhatsky , Linux-MM , linux-kernel On 06/03/2014 06:19 AM, Dan Streetman wrote: > In order to allow zswap users to choose between zbud and zsmalloc for > the compressed storage pool, this patch set adds a new api "zpool" that > provides an interface to both zbud and zsmalloc. Only minor changes > to zbud's interface were needed. This does not include implementing > shrinking in zsmalloc, which will be sent separately. > > I believe Seth originally was using zsmalloc for swap, but there were > concerns about how significant the impact of shrinking zsmalloc would > be when zswap had to start reclaiming pages. That still may be an > issue, but this at least allows users to choose themselves whether > they want a lower-density or higher-density compressed storage medium. > At least for situations where zswap reclaim is never or rarely reached, > it probably makes sense to use the higher density of zsmalloc. > Nice job! I also made a attempt last year, but didn't finish. > Note this patch set does not change zram to use zpool, although that > change should be possible as well. > This version looks good to me! Reviewed-by: Bob Liu > --- > > Changes since v3 : https://lkml.org/lkml/2014/5/24/130 > -In zpool_shrink() use # pages instead of # bytes > -Add reclaimed param to zpool_shrink() to indicate to caller > # pages actually reclaimed > -move module usage counting to zpool, from zbud/zsmalloc > -update zbud_zpool_shrink() to call zbud_reclaim_page() in a > loop until requested # pages have been reclaimed (or error) > > Changes since v2 : https://lkml.org/lkml/2014/5/7/927 > -Change zpool to use driver registration instead of hardcoding > implementations > -Add module use counting in zbud/zsmalloc > > Changes since v1 https://lkml.org/lkml/2014/4/19/97 > -remove zsmalloc shrinking > -change zbud size param type from unsigned int to size_t > -remove zpool fallback creation > -zswap manually falls back to zbud if specified type fails > > > Dan Streetman (6): > mm/zbud: zbud_alloc() minor param change > mm/zbud: change zbud_alloc size type to size_t > mm/zpool: implement common zpool api to zbud/zsmalloc > mm/zpool: zbud/zsmalloc implement zpool > mm/zpool: update zswap to use zpool > mm/zpool: prevent zbud/zsmalloc from unloading when used > > include/linux/zbud.h | 2 +- > include/linux/zpool.h | 224 ++++++++++++++++++++++++++++++++++++++++++++++++++ > mm/Kconfig | 43 ++++++---- > mm/Makefile | 1 + > mm/zbud.c | 123 +++++++++++++++++++++++---- > mm/zpool.c | 206 ++++++++++++++++++++++++++++++++++++++++++++++ > mm/zsmalloc.c | 83 +++++++++++++++++++ > mm/zswap.c | 76 ++++++++++------- > 8 files changed, 694 insertions(+), 64 deletions(-) > create mode 100644 include/linux/zpool.h > create mode 100644 mm/zpool.c > -- Regards, -Bob -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org