Re: [next:master 156/212] fs/binfmt_elf.c:158:18: note: in expansion of macro 'min'

[Jeff Liu <jeff.liu@oracle.com>]

On 06/26/2014 03:59 PM, Andrew Morton wrote:
> On Wed, 25 Jun 2014 19:30:27 +0800 Jeff Liu <jeff.liu@oracle.com> wrote:
> 
>>
>> On 06/25/2014 18:02 PM, Fengguang Wu wrote:

<snip>

>>>    fs/binfmt_elf.c: In function 'get_atrandom_bytes':
>>>    include/linux/kernel.h:713:17: warning: comparison of distinct pointer types lacks a cast
>>>      (void) (&_min1 == &_min2);  \
>>>                     ^
>>>>> fs/binfmt_elf.c:158:18: note: in expansion of macro 'min'
>>>       size_t chunk = min(nbytes, sizeof(random_variable));
>>
>> I remember we have the same report on arch mn10300 about half a year ago, but the code
>> is correct. :)
> 
> We really need to do something about this patch - it's been stuck in
> -mm for ever.
> 
> I have a note here that Stephan Mueller identified issues with it but I
> don't recall what they were - do you? 

Yes, Stephan noted a couple of issues here:
https://lkml.org/lkml/2012/12/14/267

> 
> Maybe you could go back through the list dicussion, identify all/any
> issues which were raised, update the changelog to address them then
> resend it, copying people who were involved in the earlier discussion?

Ok, I'll take care of it.


Cheers,
-Jeff

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>