From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yh0-f50.google.com (mail-yh0-f50.google.com [209.85.213.50]) by kanga.kvack.org (Postfix) with ESMTP id 8143C6B0031 for ; Thu, 26 Jun 2014 02:33:17 -0400 (EDT) Received: by mail-yh0-f50.google.com with SMTP id t59so1883368yho.9 for ; Wed, 25 Jun 2014 23:33:17 -0700 (PDT) Received: from userp1040.oracle.com (userp1040.oracle.com. [156.151.31.81]) by mx.google.com with ESMTPS id 5si9107128yhd.95.2014.06.25.23.33.16 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 25 Jun 2014 23:33:16 -0700 (PDT) Message-ID: <53ABBEA0.1010307@oracle.com> Date: Thu, 26 Jun 2014 14:33:04 +0800 From: Jeff Liu MIME-Version: 1.0 Subject: Re: [next:master 156/212] fs/binfmt_elf.c:158:18: note: in expansion of macro 'min' References: <53aa90d2.Yd3WgTmElIsuiwuV%fengguang.wu@intel.com> <20140625100213.GA1866@localhost> <53AAB2D3.2050809@oracle.com> <53AB7F0B.5050900@oracle.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: David Rientjes Cc: Fengguang Wu , kbuild-all@01.org, Andrew Morton , Linux Memory Management List On 06/26/2014 14:19 PM, David Rientjes wrote: > On Thu, 26 Jun 2014, Jeff Liu wrote: > >>>>> fs/binfmt_elf.c: In function 'get_atrandom_bytes': >>>>> include/linux/kernel.h:713:17: warning: comparison of distinct pointer types lacks a cast >>>>> (void) (&_min1 == &_min2); \ >>>>> ^ >>>>>>> fs/binfmt_elf.c:158:18: note: in expansion of macro 'min' >>>>> size_t chunk = min(nbytes, sizeof(random_variable)); >>>> >>>> I remember we have the same report on arch mn10300 about half a year ago, but the code >>>> is correct. :) >>>> >>> >>> Casting the sizeof operator to size_t would fix this issue on am33. >> >> Thanks for pointing this out, I once considered to use min_t() to do explicitly casting. >> However, both values to compare are already size_t, maybe this depending on the compiler's >> result of what sizeof() would be... >> > > Have you read arch/mn10300/include/uapi/asm/posix_types.h? am33 defines > this to be unsigned int for gcc version 4. You would not see this warning > with gcc major version != 4 or if you do what I suggested and cast it to > size_t. Ah, that solves it, thanks! 0day tests with am33 cross compiler version 4.6.3. Cheers, -Jeff -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org