* [mmotm:master 212/319] fs/nilfs2/sysfs.c:256:1: sparse: symbol 'nilfs_sysfs_create_mounted_snapshots_group' was not declared. Should it be static?
@ 2014-06-26 8:38 kbuild test robot
2014-06-26 12:59 ` Vyacheslav Dubeyko
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2014-06-26 8:38 UTC (permalink / raw)
To: Vyacheslav Dubeyko
Cc: Linux Memory Management List, Andrew Morton, Johannes Weiner,
kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1104 bytes --]
tree: git://git.cmpxchg.org/linux-mmotm.git master
head: 9477ec75947f2cf0fc47e8ab781a5e9171099be2
commit: c4d5ec2ba1ab268de64dcad7c6544d99a2218999 [212/319] nilfs2: integrate sysfs support into driver
reproduce: make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> fs/nilfs2/sysfs.c:256:1: sparse: symbol 'nilfs_sysfs_create_mounted_snapshots_group' was not declared. Should it be static?
>> fs/nilfs2/sysfs.c:369:1: sparse: symbol 'nilfs_sysfs_create_checkpoints_group' was not declared. Should it be static?
>> fs/nilfs2/sysfs.c:458:1: sparse: symbol 'nilfs_sysfs_create_segments_group' was not declared. Should it be static?
>> fs/nilfs2/sysfs.c:720:1: sparse: symbol 'nilfs_sysfs_create_segctor_group' was not declared. Should it be static?
>> fs/nilfs2/sysfs.c:846:1: sparse: symbol 'nilfs_sysfs_create_superblock_group' was not declared. Should it be static?
Please consider folding the attached diff :-)
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
[-- Attachment #2: make-it-static-c4d5ec2ba1ab268de64dcad7c6544d99a2218999.diff --]
[-- Type: text/x-diff, Size: 2706 bytes --]
From: Fengguang Wu <fengguang.wu@intel.com>
Subject: [PATCH mmotm] nilfs2: nilfs_sysfs_create_mounted_snapshots_group can be static
TO: Vyacheslav Dubeyko <Vyacheslav.Dubeyko@hgst.com>
CC: Johannes Weiner <hannes@cmpxchg.org>
CC: linux-nilfs@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: Vyacheslav Dubeyko <Vyacheslav.Dubeyko@hgst.com>
CC: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
sysfs.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/fs/nilfs2/sysfs.c b/fs/nilfs2/sysfs.c
index 0f6148c..46ca55b 100644
--- a/fs/nilfs2/sysfs.c
+++ b/fs/nilfs2/sysfs.c
@@ -253,7 +253,7 @@ static struct attribute *nilfs_mounted_snapshots_attrs[] = {
NILFS_DEV_INT_GROUP_OPS(mounted_snapshots, dev);
NILFS_DEV_INT_GROUP_TYPE(mounted_snapshots, dev);
-NILFS_DEV_INT_GROUP_FNS(mounted_snapshots, dev);
+static NILFS_DEV_INT_GROUP_FNS(mounted_snapshots, dev);
/************************************************************************
* NILFS checkpoints attrs *
@@ -366,7 +366,7 @@ static struct attribute *nilfs_checkpoints_attrs[] = {
NILFS_DEV_INT_GROUP_OPS(checkpoints, dev);
NILFS_DEV_INT_GROUP_TYPE(checkpoints, dev);
-NILFS_DEV_INT_GROUP_FNS(checkpoints, dev);
+static NILFS_DEV_INT_GROUP_FNS(checkpoints, dev);
/************************************************************************
* NILFS segments attrs *
@@ -455,7 +455,7 @@ static struct attribute *nilfs_segments_attrs[] = {
NILFS_DEV_INT_GROUP_OPS(segments, dev);
NILFS_DEV_INT_GROUP_TYPE(segments, dev);
-NILFS_DEV_INT_GROUP_FNS(segments, dev);
+static NILFS_DEV_INT_GROUP_FNS(segments, dev);
/************************************************************************
* NILFS segctor attrs *
@@ -717,7 +717,7 @@ static struct attribute *nilfs_segctor_attrs[] = {
NILFS_DEV_INT_GROUP_OPS(segctor, dev);
NILFS_DEV_INT_GROUP_TYPE(segctor, dev);
-NILFS_DEV_INT_GROUP_FNS(segctor, dev);
+static NILFS_DEV_INT_GROUP_FNS(segctor, dev);
/************************************************************************
* NILFS superblock attrs *
@@ -843,7 +843,7 @@ static struct attribute *nilfs_superblock_attrs[] = {
NILFS_DEV_INT_GROUP_OPS(superblock, dev);
NILFS_DEV_INT_GROUP_TYPE(superblock, dev);
-NILFS_DEV_INT_GROUP_FNS(superblock, dev);
+static NILFS_DEV_INT_GROUP_FNS(superblock, dev);
/************************************************************************
* NILFS device attrs *
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [mmotm:master 212/319] fs/nilfs2/sysfs.c:256:1: sparse: symbol 'nilfs_sysfs_create_mounted_snapshots_group' was not declared. Should it be static?
2014-06-26 8:38 [mmotm:master 212/319] fs/nilfs2/sysfs.c:256:1: sparse: symbol 'nilfs_sysfs_create_mounted_snapshots_group' was not declared. Should it be static? kbuild test robot
@ 2014-06-26 12:59 ` Vyacheslav Dubeyko
0 siblings, 0 replies; 2+ messages in thread
From: Vyacheslav Dubeyko @ 2014-06-26 12:59 UTC (permalink / raw)
To: kbuild test robot
Cc: Linux Memory Management List, Andrew Morton, Johannes Weiner,
kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1173 bytes --]
On 06/26/2014 12:38 PM, kbuild test robot wrote:
> tree: git://git.cmpxchg.org/linux-mmotm.git master
> head: 9477ec75947f2cf0fc47e8ab781a5e9171099be2
> commit: c4d5ec2ba1ab268de64dcad7c6544d99a2218999 [212/319] nilfs2: integrate sysfs support into driver
> reproduce: make C=1 CF=-D__CHECK_ENDIAN__
>
>
> sparse warnings: (new ones prefixed by >>)
>
>>> fs/nilfs2/sysfs.c:256:1: sparse: symbol 'nilfs_sysfs_create_mounted_snapshots_group' was not declared. Should it be static?
>>> fs/nilfs2/sysfs.c:369:1: sparse: symbol 'nilfs_sysfs_create_checkpoints_group' was not declared. Should it be static?
>>> fs/nilfs2/sysfs.c:458:1: sparse: symbol 'nilfs_sysfs_create_segments_group' was not declared. Should it be static?
>>> fs/nilfs2/sysfs.c:720:1: sparse: symbol 'nilfs_sysfs_create_segctor_group' was not declared. Should it be static?
>>> fs/nilfs2/sysfs.c:846:1: sparse: symbol 'nilfs_sysfs_create_superblock_group' was not declared. Should it be static?
> Please consider folding the attached diff :-)
The diff looks good for me. But what about to fix the issue in the source?
Please, find my vision of the patch in the attachment.
Thanks,
Vyacheslav Dubeyko.
[-- Attachment #2: 0001-nilfs2-nilfs_sysfs_create_mounted_snapshots_group-ca.patch --]
[-- Type: text/x-patch, Size: 1336 bytes --]
From: Fengguang Wu <fengguang.wu@intel.com>
Subject: [PATCH mmotm] nilfs2: nilfs_sysfs_create_mounted_snapshots_group can be static
TO: Vyacheslav Dubeyko <Vyacheslav.Dubeyko@hgst.com>
CC: Johannes Weiner <hannes@cmpxchg.org>
CC: linux-nilfs@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: Vyacheslav Dubeyko <Vyacheslav.Dubeyko@hgst.com>
CC: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
fs/nilfs2/sysfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/nilfs2/sysfs.c b/fs/nilfs2/sysfs.c
index 0f6148c..bbb0dcc 100644
--- a/fs/nilfs2/sysfs.c
+++ b/fs/nilfs2/sysfs.c
@@ -87,7 +87,7 @@ static struct kobj_type nilfs_##name##_ktype = { \
};
#define NILFS_DEV_INT_GROUP_FNS(name, parent_name) \
-int nilfs_sysfs_create_##name##_group(struct the_nilfs *nilfs) \
+static int nilfs_sysfs_create_##name##_group(struct the_nilfs *nilfs) \
{ \
struct kobject *parent; \
struct kobject *kobj; \
@@ -106,7 +106,7 @@ int nilfs_sysfs_create_##name##_group(struct the_nilfs *nilfs) \
return err; \
return 0; \
} \
-void nilfs_sysfs_delete_##name##_group(struct the_nilfs *nilfs) \
+static void nilfs_sysfs_delete_##name##_group(struct the_nilfs *nilfs) \
{ \
kobject_del(&nilfs->ns_##parent_name##_subgroups->sg_##name##_kobj); \
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-26 12:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-26 8:38 [mmotm:master 212/319] fs/nilfs2/sysfs.c:256:1: sparse: symbol 'nilfs_sysfs_create_mounted_snapshots_group' was not declared. Should it be static? kbuild test robot
2014-06-26 12:59 ` Vyacheslav Dubeyko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).