From: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Fengguang Wu <fengguang.wu@intel.com>,
David Cohen <david.a.cohen@linux.intel.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Damien Ramonda <damien.ramonda@intel.com>,
Jan Kara <jack@suse.cz>, David Rientjes <rientjes@google.com>,
Nishanth Aravamudan <nacc@linux.vnet.ibm.com>,
linux-mm <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm readahead: Fix sys_readahead breakage by reverting 2MB limit (bug 79111)
Date: Thu, 03 Jul 2014 23:41:01 +0530 [thread overview]
Message-ID: <53B59CB5.9060004@linux.vnet.ibm.com> (raw)
In-Reply-To: <CA+55aFxOTqUAqEF7+83s890Q18qCHSQqDOxWqWHNjG_25hVhXg@mail.gmail.com>
On 07/03/2014 09:11 PM, Linus Torvalds wrote:
> On Thu, Jul 3, 2014 at 6:02 AM, Raghavendra K T
> <raghavendra.kt@linux.vnet.ibm.com> wrote:
>>
>> However it broke sys_readahead semantics: 'readahead() blocks until the specified
>> data has been read'
>
> What? Where did you find that insane sentence? And where did you find
> an application that depends on that totally insane semantics that sure
> as hell was never intentional.
>
> If this comes from some man-page,
Yes it is.
then the man-page is just full of
> sh*t, and is being crazy. The whole and *only* point of readahead() is
> that it does *not* block, and you can do it across multiple files.
Entirely agree. Infact I also had the strong opinion that we should
rather change man page instead of making Linux performing badly by doing
large unnecessary readahead when there is no actual read, and
performance numbers have proved that.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-07-03 18:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 13:02 [PATCH] mm readahead: Fix sys_readahead breakage by reverting 2MB limit (bug 79111) Raghavendra K T
2014-07-03 15:41 ` Linus Torvalds
2014-07-03 18:11 ` Raghavendra K T [this message]
2014-07-03 18:22 ` Linus Torvalds
2014-07-03 18:29 ` Linus Torvalds
2014-07-03 18:38 ` Raghavendra K T
2014-07-03 18:50 ` Raghavendra K T
2014-07-03 18:53 ` Linus Torvalds
2014-07-03 18:56 ` Raghavendra K T
2014-07-03 19:05 ` Dave Jones
2014-07-03 19:43 ` John Stoffel
2014-07-03 21:58 ` Linus Torvalds
2014-10-03 20:57 ` Rafael Aquini
2014-07-03 18:35 ` Raghavendra K T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B59CB5.9060004@linux.vnet.ibm.com \
--to=raghavendra.kt@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=damien.ramonda@intel.com \
--cc=david.a.cohen@linux.intel.com \
--cc=fengguang.wu@intel.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nacc@linux.vnet.ibm.com \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).