From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f181.google.com (mail-pd0-f181.google.com [209.85.192.181]) by kanga.kvack.org (Postfix) with ESMTP id DE3216B0038 for ; Mon, 21 Jul 2014 17:22:36 -0400 (EDT) Received: by mail-pd0-f181.google.com with SMTP id g10so8404483pdj.40 for ; Mon, 21 Jul 2014 14:22:36 -0700 (PDT) Received: from smtp.codeaurora.org (smtp.codeaurora.org. [198.145.11.231]) by mx.google.com with ESMTPS id d7si7747826pdj.181.2014.07.21.14.22.35 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Jul 2014 14:22:35 -0700 (PDT) Message-ID: <53CD849A.1000800@codeaurora.org> Date: Mon, 21 Jul 2014 14:22:34 -0700 From: Laura Abbott MIME-Version: 1.0 Subject: Re: [PATCHv4 4/5] arm: use genalloc for the atomic pool References: <1404324218-4743-1-git-send-email-lauraa@codeaurora.org> <1404324218-4743-5-git-send-email-lauraa@codeaurora.org> <20140704134254.GA4142@ulmo> In-Reply-To: <20140704134254.GA4142@ulmo> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Thierry Reding Cc: Will Deacon , Catalin Marinas , David Riley , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ritesh Harjain , linux-arm-kernel@lists.infradead.org On 7/4/2014 6:42 AM, Thierry Reding wrote: > On Wed, Jul 02, 2014 at 11:03:37AM -0700, Laura Abbott wrote: > [...] >> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c > [...] >> index f5190ac..02a1939 100644 >> --- a/arch/arm/mm/dma-mapping.c >> +++ b/arch/arm/mm/dma-mapping.c >> @@ -26,6 +26,7 @@ >> #include >> #include >> #include >> +#include > > Includes should be sorted alphabetically. I realize that's not the case > for this particular file, but the downside of that is that your patch no > longer applies cleanly on top of linux-next because some other patch did > add linux/cma.h at the same location. > Yes, I'll fix that up. I'll put genalloc.h before gfp.h. >> static int __init early_coherent_pool(char *p) >> { >> - atomic_pool.size = memparse(p, &p); >> + atomic_pool_size = memparse(p, &p); >> return 0; >> } >> early_param("coherent_pool", early_coherent_pool); >> >> + > > There's a gratuituous blank line her. > > I also need the below hunk on top of you patch to make this compile on > ARM. > Yes, that does indeed need to be fixed up. Thanks, Laura -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org