From: Chintan Pandya <cpandya@codeaurora.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: BUG when __kmap_atomic_idx crosses boundary
Date: Thu, 31 Jul 2014 11:06:29 +0530 [thread overview]
Message-ID: <53D9D5DD.6030603@codeaurora.org> (raw)
In-Reply-To: <20140730020615.2f943cf7.akpm@linux-foundation.org>
On 07/30/2014 02:36 PM, Andrew Morton wrote:
> On Wed, 30 Jul 2014 14:22:35 +0530 Chintan Pandya<cpandya@codeaurora.org> wrote:
>
>> __kmap_atomic_idx>= KM_TYPE_NR or< ZERO is a bug.
>> Report it even if CONFIG_DEBUG_HIGHMEM is not enabled.
>> That saves much debugging efforts.
>
> Please take considerably more care when preparing patch changelogs.
Okay. I will prepare new commit message.
>
> kmap_atomic() is a very commonly called function so we'll need much
> more detail than this to justify adding overhead to it.
>
> I don't think CONFIG_DEBUG_HIGHMEM really needs to exist. We could do
> s/CONFIG_DEBUG_HIGHMEM/CONFIG_DEBUG_VM/g and perhaps your secret bug
> whatever it was would have been found more easily.
Um, we didn't get bug directly hitting here.
>
__kmap_atomic_idx should not be equal to KM_TYPE_NR anyway. So, at least
I will share that patch. For changing DEBUG_HIGHMEM to DEBUG_VM, I will
work on it.
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of the Code Aurora Forum, hosted by The Linux Foundation
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2014-07-31 5:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 8:52 [PATCH] mm: BUG when __kmap_atomic_idx crosses boundary Chintan Pandya
2014-07-30 9:06 ` Andrew Morton
2014-07-30 10:37 ` Davidlohr Bueso
2014-07-30 10:52 ` Davidlohr Bueso
2014-07-31 5:36 ` Chintan Pandya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D9D5DD.6030603@codeaurora.org \
--to=cpandya@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).