From: Laura Abbott <lauraa@codeaurora.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Russell King <linux@arm.linux.org.uk>,
David Riley <davidriley@chromium.org>,
linux-arm-kernel@lists.infradead.org,
Ritesh Harjain <ritesh.harjani@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCHv6 1/5] lib/genalloc.c: Add power aligned algorithm
Date: Fri, 08 Aug 2014 15:41:51 -0700 [thread overview]
Message-ID: <53E5522F.10603@codeaurora.org> (raw)
In-Reply-To: <20140808153635.36f27a4fbfbd8f715e51d15e@linux-foundation.org>
On 8/8/2014 3:36 PM, Andrew Morton wrote:
> On Fri, 8 Aug 2014 13:23:13 -0700 Laura Abbott <lauraa@codeaurora.org> wrote:
>
>>
>> One of the more common algorithms used for allocation
>> is to align the start address of the allocation to
>> the order of size requested. Add this as an algorithm
>> option for genalloc.
>>
>> --- a/lib/genalloc.c
>> +++ b/lib/genalloc.c
>> @@ -481,6 +481,27 @@ unsigned long gen_pool_first_fit(unsigned long *map, unsigned long size,
>> EXPORT_SYMBOL(gen_pool_first_fit);
>>
>> /**
>> + * gen_pool_first_fit_order_align - find the first available region
>> + * of memory matching the size requirement. The region will be aligned
>> + * to the order of the size specified.
>> + * @map: The address to base the search on
>> + * @size: The bitmap size in bits
>> + * @start: The bitnumber to start searching at
>> + * @nr: The number of zeroed bits we're looking for
>> + * @data: additional data - unused
>
> `data' is used.
>
>> + */
>> +unsigned long gen_pool_first_fit_order_align(unsigned long *map,
>> + unsigned long size, unsigned long start,
>> + unsigned int nr, void *data)
>> +{
>> + unsigned long order = (unsigned long) data;
>
> Why pass a void*? Why not pass "unsigned order;"?
>
>> + unsigned long align_mask = (1 << get_order(nr << order)) - 1;
>> +
>> + return bitmap_find_next_zero_area(map, size, start, nr, align_mask);
>> +}
>> +EXPORT_SYMBOL(gen_pool_first_fit_order_align);
>> +
>> +/**
>> * gen_pool_best_fit - find the best fitting region of memory
>> * macthing the size requirement (no alignment constraint)
>> * @map: The address to base the search on
>
Ugh, I sent out the wrong version of this one which updated the function to
not need the parameter. I'll update with the correct version in v7.
Laura
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2014-08-08 22:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 20:23 [PATCHv6 1/5] lib/genalloc.c: Add power aligned algorithm Laura Abbott
2014-08-08 20:23 ` [PATCHv6 2/5] lib/genalloc.c: Add genpool range check function Laura Abbott
2014-08-08 22:40 ` Andrew Morton
2014-08-08 20:23 ` [PATCHv6 3/5] common: dma-mapping: Introduce common remapping functions Laura Abbott
2014-08-08 22:45 ` Andrew Morton
2014-08-08 23:25 ` Laura Abbott
2014-08-11 18:05 ` Catalin Marinas
2014-08-11 18:04 ` Catalin Marinas
2014-08-08 20:23 ` [PATCHv6 4/5] arm: use genalloc for the atomic pool Laura Abbott
2014-08-08 20:23 ` [PATCHv6 5/5] arm64: Add atomic pool for non-coherent and CMA allocations Laura Abbott
2014-08-08 22:36 ` [PATCHv6 1/5] lib/genalloc.c: Add power aligned algorithm Andrew Morton
2014-08-08 22:41 ` Laura Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E5522F.10603@codeaurora.org \
--to=lauraa@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=davidriley@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=ritesh.harjani@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).