From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f175.google.com (mail-we0-f175.google.com [74.125.82.175]) by kanga.kvack.org (Postfix) with ESMTP id 257FE6B0035 for ; Mon, 22 Sep 2014 16:23:59 -0400 (EDT) Received: by mail-we0-f175.google.com with SMTP id u57so2711283wes.34 for ; Mon, 22 Sep 2014 13:23:58 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id iu6si9443468wic.41.2014.09.22.13.23.56 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Sep 2014 13:23:57 -0700 (PDT) Message-ID: <54208422.8010209@redhat.com> Date: Mon, 22 Sep 2014 16:18:42 -0400 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH] kvm: Fix page ageing bugs References: <1411415878-30346-1-git-send-email-andreslc@google.com> In-Reply-To: <1411415878-30346-1-git-send-email-andreslc@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Andres Lagar-Cavilla , Gleb Natapov , Radim Krcmar , Paolo Bonzini , Andrew Morton , Andrea Arcangeli , Peter Feiner , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Andres Lagar-Cavilla -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 09/22/2014 03:57 PM, Andres Lagar-Cavilla wrote: > 1. We were calling clear_flush_young_notify in unmap_one, but we > are within an mmu notifier invalidate range scope. The spte exists > no more (due to range_start) and the accessed bit info has already > been propagated (due to kvm_pfn_set_accessed). Simply call > clear_flush_young. > > 2. We clear_flush_young on a primary MMU PMD, but this may be > mapped as a collection of PTEs by the secondary MMU (e.g. during > log-dirty). This required expanding the interface of the > clear_flush_young mmu notifier, so a lot of code has been trivially > touched. > > 3. In the absence of shadow_accessed_mask (e.g. EPT A bit), we > emulate the access bit by blowing the spte. This requires proper > synchronizing with MMU notifier consumers, like every other removal > of spte's does. Acked-by: Rik van Riel - -- All rights reversed -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUIIQiAAoJEM553pKExN6DWeoH/RpkYF1QCxnbxgZhnioaWjyu Rp/kN6Rck6Eu3k/yRI6k+8IhgUJWkVhSXybTIDl1X6aVGgYwhaeOv2zPPfshfM6h ABE3pLFjs2qtdotZXFSvZ4mNwbQE73YHphAbmFUBSdm2Oz1bj6Qfq+KYFdM+aQd7 UYIFgtdGg/tyLMqE25J7pAnSDRR5GKmAKLvkFjN3Q8O4ynD3rExH1yTMLtQbyKvb oadSzaQLBOkLDAj3rpiOTl52B2tlQS+cxWqEfzA/AXOK8TkllDKIQT5BeRXV5O1c /WsZmusiA6KYgjLxnL0K9XJpgpOQ5unYAFyIGgYmKiaN6PQsd+pGM5GDnOWGorE= =dftO -----END PGP SIGNATURE----- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org