From: Rik van Riel <riel@redhat.com>
To: Paul McQuade <paulmcquad@gmail.com>
Cc: akpm@linux-foundation.org, hughd@google.com, gorcunov@openvz.org,
kirill.shutemov@linux.intel.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: fremap use linux header
Date: Thu, 02 Oct 2014 12:23:34 -0400 [thread overview]
Message-ID: <542D7C06.1070501@redhat.com> (raw)
In-Reply-To: <1412264057-3146-1-git-send-email-paulmcquad@gmail.com>
On 10/02/2014 11:34 AM, Paul McQuade wrote:
> Use #include <linux/mmu_context.h> instead of <asm/mmu_context.h>
linux/mmu_context.h does not include asm/mmu_context.h
This leads me to believe that either fremap.c does not use
any definitions from either mmu_context.h file, or after
your change the code that fremap.c needs is no longer directly
included (but only imported indirectly due to sheer luck).
Could you verify which of these is the case?
If fremap.c is not using any code from mmu_context.h, we are
better off simply removing that line, instead of replacing it
with an unnecessary include...
> diff --git a/mm/fremap.c b/mm/fremap.c
> index 72b8fa3..d614f1c 100644
> --- a/mm/fremap.c
> +++ b/mm/fremap.c
> @@ -1,6 +1,6 @@
> /*
> * linux/mm/fremap.c
> - *
> + *
> * Explicit pagetable population and nonlinear (random) mappings support.
> *
> * started by Ingo Molnar, Copyright (C) 2002, 2003
> @@ -16,8 +16,8 @@
> #include <linux/rmap.h>
> #include <linux/syscalls.h>
> #include <linux/mmu_notifier.h>
> +#include <linux/mmu_context.h>
>
> -#include <asm/mmu_context.h>
> #include <asm/cacheflush.h>
> #include <asm/tlbflush.h>
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2014-10-02 17:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 15:34 [PATCH] mm: fremap use linux header Paul McQuade
2014-10-02 16:23 ` Rik van Riel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542D7C06.1070501@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=gorcunov@openvz.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=paulmcquad@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).