From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8795DC10DC1 for ; Thu, 7 Dec 2023 02:33:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 086F56B0083; Wed, 6 Dec 2023 21:33:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 036C66B0085; Wed, 6 Dec 2023 21:33:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E68816B0088; Wed, 6 Dec 2023 21:33:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D6DB16B0083 for ; Wed, 6 Dec 2023 21:33:00 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id AE765A032D for ; Thu, 7 Dec 2023 02:33:00 +0000 (UTC) X-FDA: 81538449720.23.090973D Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) by imf05.hostedemail.com (Postfix) with ESMTP id A93EE100008 for ; Thu, 7 Dec 2023 02:32:58 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=tOpou7Zj; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf05.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.186 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701916379; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XaTAr3n1Zo+WQ9fxFhHx7mUs6gY/pefswV7mSrJu1Fs=; b=s85vqsFt3KE3uzwRwiaORnJTHJl4twMjTVnIjU5RlezWooK8Je9XBaDDt6fyANnmruenRm PD3/jkzV5N0Kb0Zdv5BXeFY9Zk9rD7BlL01rIBxYgb4+qWhhohlEdHmreWyCH1+V16m+uS SEIz/6pHky3/zXUsu92xfA3g1PrG9hQ= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=tOpou7Zj; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf05.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.186 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701916379; a=rsa-sha256; cv=none; b=W2fjA6oWdzMNHcJX51XFS+PKKccy7ijtb4t+1RIX6juXU0xqXJHBsBSIhvF7D3aaarkTAR EVyFkWADX+89bMx2CohTtSmHN84bYeeu4XJwUbS9RfKK4oTCrAVPFHCgDkMB64ipzsZwdU oG4zDmXFxgQ1P24dtWztorOublPDS6Y= Message-ID: <544aad70-0492-496c-8747-ff6b2a204b3e@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1701916375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XaTAr3n1Zo+WQ9fxFhHx7mUs6gY/pefswV7mSrJu1Fs=; b=tOpou7Zj9UjoYiMxw+NoscyXn9cK0IYzeHsVMBiOwD0nec5YxQ0rQp1TMC3hIXUIaThmev 3teqqT5qXRJE6u4ptQpmA4CSU0IX5NLOj/w1+HipZklpBVwLWh2sccQ9nW3H7/ZZUQi1TE I3tnOXYu5KHOJvs4ymbxt3WpxqT6fZ0= Date: Thu, 7 Dec 2023 10:32:48 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v8 6/6] zswap: shrinks zswap pool based on memory pressure Content-Language: en-US To: Nhat Pham , Yosry Ahmed Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, cerasuolodomenico@gmail.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, chrisl@kernel.org, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, shuah@kernel.org References: <20231130194023.4102148-1-nphamcs@gmail.com> <20231130194023.4102148-7-nphamcs@gmail.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: A93EE100008 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: yydmrb9pmzqzt9nwoyt1q7hdttseru5u X-HE-Tag: 1701916378-308709 X-HE-Meta: U2FsdGVkX19YBX3KtHYLOh8ZTVmZJX8lnh+5V9UejrAv47KvUshbZz7muGHJE+XQ6vKJeJ1f/lkQKWBoUeGHk6y2Z1opGBCEBDEoBWJ/53WmAZ1DlssWBi03bfpHob1Esr88rhmORDTiZBLC3yqzBJcteJ0tGXAWqcZnR0yXIlJbFbKBFuE1Zdc3BpWt8OQbewP9oM2d7hQZ00TNeajr0urfsDD56rGE0ROGM0E8t2hQYBcFXL7MKNWw343sxXPrEYYbA3SqfyHAT6r3aGhJ+iFNZDB9yoeHlLGzZvFbq8ruRzH5eJuEd4JJmrd7TOfjYm2cSQQTiIWyZZddoNIc+jC2+zqZsBiQrjXCGx0ksTDGn2GqKiikzZ6eC6mQ0pWk6JGqu6eQ1nRbkgfLkWCwqYG4PT0JjHPATqN/lSY/4RPLLJorgxQvQGhWQ+puvjAF7EIgsR5rWu4XTrKUQdRPE8rR+T2cPqMkbTK8XLdUvRy6WzokMBfYDCYRb49JcI1yo3IIlL9Wq/DY2UFAKelpi3w5IuBBRZ6vhyaeY0dSLtNC6RurPclfyghZ2EyERqTi0igaPuY3ZH14Zs/f+zHAIAaSuu/IdWoiiOJ5BzDzLAqZ1yxBOwbRqzY1JZsk5UCGrwaeyp1Nds/E8SaI30cgrxtxNkdVHnQwdc1daJL7K7BumaV9sh1c+Ov2pZX3cuGYdCUCSDILWboc3EACOpPBKPmu2AHXuRE+ICSa5kpc2EKJNbIxKtLx5sJ7O3Wg223mbzPNvs3fG5ygnGOiScxuQuUjXKtJIhkqW/wqKURgzSFfC9j2vOC5vabIhN4jgCrsgrqE7yiZSsCw8U90+OHCC2oWE27XE2b+53wPFTJHetCncb6GV0hjYmkzixEWJXDlXx4UT7JyDQ8p6IWSw5Tx1WnxrV2ieH+2abqonMjGSyY1/vDlQRhYM4oIqYIinrrG8UFW0cVe54KB5Up5FQw LAoSGbws Yn6edSgwLz9q0AMMO/m9V1I5nnni7jln6ay1inwZPNVMAEsMbO1OUvV1p6WaOfDqRuY+o8NRmVbJHi6IMtTZjQgXZ7Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2023/12/7 03:47, Nhat Pham wrote: > [...] >> >> Hmm so how should we proceed from here? How about this: >> >> a) I can send a fixlet to move the enablement check above the stats >> flushing + use mem_cgroup_flush_stats >> b) Then maybe, you can send a fixlet to update this new callsite? >> >> Does that sound reasonable? > > I just sent out the fixlet. Yosry and Chengming, let me know if that > looks good. Thank you both for detecting this issue and proposing the > fix! Yeah, also looks good to me. Thanks! -- Best regards, Chengming Zhou