From: Peter Hurley <peter@hurleysoftware.com>
To: Michal Nazarewicz <mina86@mina86.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Minchan Kim <minchan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: CMA: test_pages_isolated failures in alloc_contig_range
Date: Mon, 03 Nov 2014 22:38:48 -0500 [thread overview]
Message-ID: <54584A48.9000409@hurleysoftware.com> (raw)
In-Reply-To: <xa1tfve8ku7q.fsf@mina86.com>
On 10/28/2014 12:57 PM, Michal Nazarewicz wrote:
>> On 10/28/2014 08:38 AM, Michal Nazarewicz wrote:
>>> Like Laura wrote, the message is not (should not be) a problem in
>>> itself:
>>
>> [...]
>>
>>> So as you can see cma_alloc will try another part of the cma region if
>>> test_pages_isolated fails.
>>>
>>> Obviously, if CMA region is fragmented or there's enough space for only
>>> one allocation of required size isolation failures will cause allocation
>>> failures, so it's best to avoid them, but they are not always avoidable.
>>>
>>> To debug you would probably want to add more debug information about the
>>> page (i.e. data from struct page) that failed isolation after the
>>> pr_warn in alloc_contig_range.
>
> On Tue, Oct 28 2014, Peter Hurley <peter@hurleysoftware.com> wrote:
>> If the message does not indicate an actual problem, then its printk level is
>> too high. These messages have been reported when using 3.16+ distro kernels.
>
> I think it could be argued both ways. The condition is not an error,
> since in many cases cma_alloc will be able to continue, but it *is* an
> undesired state. As such it's not an error but feels to me a bit more
> then just information, hence a warning. I don't care either way, though.
This "undesired state" is trivially reproducible on 3.16.y on the x86 arch;
a smattering of these will show up just building a distro kernel.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-11-04 3:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-26 21:09 CMA: test_pages_isolated failures in alloc_contig_range Laurent Pinchart
2014-10-27 20:38 ` Laura Abbott
2014-10-28 15:12 ` Laurent Pinchart
2014-10-28 12:38 ` Michal Nazarewicz
2014-10-28 13:48 ` Peter Hurley
2014-10-28 16:57 ` Michal Nazarewicz
2014-11-04 3:38 ` Peter Hurley [this message]
2014-10-28 18:59 ` Laurent Pinchart
2014-11-03 16:57 ` [PATCH] mm: alloc_contig_range: demote pages busy message from warn to info Michal Nazarewicz
2014-11-04 5:43 ` Minchan Kim
2014-11-04 12:22 ` Peter Hurley
2014-11-04 13:35 ` Michal Nazarewicz
2014-11-04 14:19 ` Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54584A48.9000409@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=akpm@linux-foundation.org \
--cc=b.zolnierkie@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-sh@vger.kernel.org \
--cc=mina86@mina86.com \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).