From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qa0-f43.google.com (mail-qa0-f43.google.com [209.85.216.43]) by kanga.kvack.org (Postfix) with ESMTP id E4AB26B00BE for ; Thu, 6 Nov 2014 12:17:24 -0500 (EST) Received: by mail-qa0-f43.google.com with SMTP id j7so1068115qaq.30 for ; Thu, 06 Nov 2014 09:17:24 -0800 (PST) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id m79si12843416qgm.19.2014.11.06.09.17.22 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Nov 2014 09:17:23 -0800 (PST) Message-ID: <545BACF4.2080808@redhat.com> Date: Thu, 06 Nov 2014 12:16:36 -0500 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH 1/5] mmu_notifier: add event information to address invalidation v5 References: <1415047353-29160-1-git-send-email-j.glisse@gmail.com> <1415047353-29160-2-git-send-email-j.glisse@gmail.com> In-Reply-To: <1415047353-29160-2-git-send-email-j.glisse@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org List-ID: To: j.glisse@gmail.com, akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Linus Torvalds , joro@8bytes.org, Mel Gorman , "H. Peter Anvin" , Peter Zijlstra , Andrea Arcangeli , Johannes Weiner , Larry Woodman , Dave Airlie , Brendan Conoboy , Joe Donohue , Duncan Poole , Sherry Cheung , Subhash Gutti , John Hubbard , Mark Hairgrove , Lucien Dunning , Cameron Buschardt , Arvind Gopalakrishnan , Shachar Raindel , Liran Liss , Roland Dreier , Ben Sander , Greg Stoner , John Bridgman , Michael Mantor , Paul Blinzer , Laurent Morichetti , Alexander Deucher , Oded Gabbay , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 11/03/2014 03:42 PM, j.glisse@gmail.com wrote: > From: JA(C)rA'me Glisse > > The event information will be usefull for new user of mmu_notifier > API. The event argument differentiate between a vma disappearing, a > page being write protected or simply a page being unmaped. This > allow new user to take different path for different event for > instance on unmap the resource used to track a vma are still valid > and should stay around. While if the event is saying that a vma is > being destroy it means that any resources used to track this vma > can be free. Looks good. All I found was one spelling mistake :) > + * - MMU_WRITE_BACK: memory is being written back to disk, all > write accesses + * must stop after invalidate_range_start > callback returns. Read access are + * still allowed. + * + * > - MMU_WRITE_PROTECT: memory is being writte protected (ie should be > mapped "write protected" > + * read only no matter what the vma memory protection allows). > All write + * accesses must stop after invalidate_range_start > callback returns. Read + * access are still allowed. After fixing the spelling mistake, feel free to add my Reviewed-by: Rik van Riel - -- All rights reversed -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUW6z0AAoJEM553pKExN6DN3wIALqZPmNihc/AbOc6MCnp+two do5pO0DTl61AD0SmPsjSKrADa8deHKDL3PqsEcA7aYOlwrJOkPhNxZZsq1SHscAO iw4Ar9BbI0JwBZO4xq4RwFhAVnu5r5NZEcyG1t1EqOGoOVc8NIflTNCxQYOU+vkj YxCZb4A0+e6nKe3P+tWso69AGHH5GVvFOqLy709OxneLbTVDRRBM1KzYtdkGR62i u3Xa41WGVjAa6OVYEoENloa/o8cmL9vgqPG3bhbCjR8zpBPAQ7fS3g8Ckux72mS+ UNzyoZjCGpWg7IxF94xhTvydzER0XDMancbKzrYW14YoJ3mW7ZDj58vpK25SKM8= =f2u6 -----END PGP SIGNATURE----- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org