From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 694F5C43334 for ; Thu, 2 Jun 2022 08:09:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E56526B0074; Thu, 2 Jun 2022 04:09:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E051F6B0075; Thu, 2 Jun 2022 04:09:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF3D56B0078; Thu, 2 Jun 2022 04:09:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C2AE56B0074 for ; Thu, 2 Jun 2022 04:09:04 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id B085C608A8 for ; Thu, 2 Jun 2022 08:09:04 +0000 (UTC) X-FDA: 79532570208.11.046940B Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by imf25.hostedemail.com (Postfix) with ESMTP id 03A3FA0065 for ; Thu, 2 Jun 2022 08:08:28 +0000 (UTC) Received: by mail-wr1-f52.google.com with SMTP id x17so5404994wrg.6 for ; Thu, 02 Jun 2022 01:09:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=eUM9+XnalZT18c7gwsWOLxfN4u2iAez4Y1cABKmJu7Y=; b=pEjALHln/V5MI9KV/B8S84wKMxLpaS6mFQYsQg4h1Pw54EPO1vAV8zqlmjOHzeRiKS qFAOHOdwesAKJ+PBPUEOiwmIh5shZOixMb6R4W/6Ndz9dtr+CYBytV4gTde4NlQJFuyF jtQ76iLIWD/UxnCIq420Md4LDbyHKOpT/r7DDphdjP+JT+B5PFW1yBKTJXu7XqaHcRzR rhFrfUic4ClKv1WRcrM3H8g1C61tTdejTt6RQ9oy8R66zL0YE8m5xngYIGRFiHLQb2B9 QLXUUcfzqAw24VJLu0K7m1AyLCYxCpArGXpmStRDdkq3TSF9bqhcOeiMkHio/qX/MTKu JQbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=eUM9+XnalZT18c7gwsWOLxfN4u2iAez4Y1cABKmJu7Y=; b=bNZyiBjOQevP6rIt3RSq5O8C06VU/91IT8/utmWirDA8A3Mww0SHjKONjCbRDkZbwt LaSOHvQR7ftgUCEBaQdlT7kjV4TxRYngxRFylraqsJRA3ogcomOJYwCrFSRUGI0LvdUR dDyLB8Mggrwsu5468rDqpHvw79w0jjd/zBOlh1a03t+iLsJX4CHhkFQ2QKyHjPGi+YbG DVtMppUznzQnKh0b5ZCeZ1j+eWP1pAJe1/ZXSP7Ru4UFQyHgo6Kl0qALCn3QGcf9qG5K PHZpfhPxE96O95gGtQSfrUtIRq8gGp1BhwdZydMEYhQbmjP4GaW0Md+y2MPq7kwaOAVS /eCQ== X-Gm-Message-State: AOAM532hENm26B4pzygfa0b8O2uvIu5U9PamZQxdBFbh8l67Lu2H2iUU HzM/bp5Tz0dy+YF21k3DQH19+w== X-Google-Smtp-Source: ABdhPJyJQE6sH13ogO1etQC1ENO2og0WoBGaPBG3HKHQ+nyT0I31zdiYkJyuiDyDUMe3DaMxCJwp1A== X-Received: by 2002:adf:d193:0:b0:210:2e72:48b6 with SMTP id v19-20020adfd193000000b002102e7248b6mr2483115wrc.387.1654157342024; Thu, 02 Jun 2022 01:09:02 -0700 (PDT) Received: from [10.40.36.78] ([193.52.24.5]) by smtp.gmail.com with ESMTPSA id z14-20020adfd0ce000000b0020e68dd2598sm3574188wrh.97.2022.06.02.01.09.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jun 2022 01:09:01 -0700 (PDT) Message-ID: <545ab14b-a95a-de2e-dbc6-f5688b09b47c@kernel.dk> Date: Thu, 2 Jun 2022 02:09:00 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v7 00/15] io-uring/xfs: support async buffered writes Content-Language: en-US To: Stefan Roesch , io-uring@vger.kernel.org, kernel-team@fb.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Cc: david@fromorbit.com, jack@suse.cz, hch@infradead.org References: <20220601210141.3773402-1-shr@fb.com> From: Jens Axboe In-Reply-To: <20220601210141.3773402-1-shr@fb.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=pEjALHln; dmarc=none; spf=pass (imf25.hostedemail.com: domain of axboe@kernel.dk designates 209.85.221.52 as permitted sender) smtp.mailfrom=axboe@kernel.dk X-Stat-Signature: zw93wwh4ifmzz5mn1dgkq8s9cbjqzgnb X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 03A3FA0065 X-HE-Tag: 1654157308-998555 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/1/22 3:01 PM, Stefan Roesch wrote: > This patch series adds support for async buffered writes when using both > xfs and io-uring. Currently io-uring only supports buffered writes in the > slow path, by processing them in the io workers. With this patch series it is > now possible to support buffered writes in the fast path. To be able to use > the fast path the required pages must be in the page cache, the required locks > in xfs can be granted immediately and no additional blocks need to be read > form disk. This series looks good to me now, but will need some slight rebasing since the 5.20 io_uring branch has split up the code a bit. Trivial to do though, I suspect it'll apply directly if we just change fs/io_uring.c to io_uring/rw.c instead. The bigger question is how to stage this, as it's touching a bit of fs, mm, and io_uring... -- Jens Axboe