From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 145FDC47422 for ; Mon, 29 Jan 2024 09:31:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 882F46B0089; Mon, 29 Jan 2024 04:31:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8326E6B008C; Mon, 29 Jan 2024 04:31:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FABD6B0092; Mon, 29 Jan 2024 04:31:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5E9BC6B0089 for ; Mon, 29 Jan 2024 04:31:41 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2C08AC02C8 for ; Mon, 29 Jan 2024 09:31:41 +0000 (UTC) X-FDA: 81731831202.27.1A34CB4 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf08.hostedemail.com (Postfix) with ESMTP id 6A1A3160003 for ; Mon, 29 Jan 2024 09:31:39 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf08.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706520699; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s/eHF0ATqSXEthW/cvI8Q76U2zyaeZecNnfVjElwSAA=; b=EaaVCBk5+qnNT7Eal8bmnngn6Sf/nH4EMQ8nFAg17jHElBAST3Q+FJlj+WIXdoi1ROqhGW Exjqk9hcona3SwTJDMvWX80/zgAbwVWVfI73vwwEkqS+vSQYJoHDjcSItlpsmCym0Qt7wR l/EtOeArlEUIcTr86R2a3N+WB3t27DE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf08.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706520699; a=rsa-sha256; cv=none; b=tu78rQk2C/14e70CWoOj2Cbo/gKzNa3tudjm1FireW+4Zl3QcGUdoYl3J0PTpyzIR6aCKh pfkzP7xK+oBZiQo9uKrYaG+Enwe4r9F4a8jlHskOSVeZQzK2hgalEq/6KTYaa+Ep2kV4lG 70TMbF4M1KncBmAlqmAySIP9Gr/XeFk= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F0F771FB; Mon, 29 Jan 2024 01:32:21 -0800 (PST) Received: from [10.162.42.11] (a077893.blr.arm.com [10.162.42.11]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1DA1E3F762; Mon, 29 Jan 2024 01:31:26 -0800 (PST) Message-ID: <545bb7bd-31c7-4166-9f81-778b82ece6d4@arm.com> Date: Mon, 29 Jan 2024 15:01:24 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v3 07/35] mm: cma: Add CMA_RELEASE_{SUCCESS,FAIL} events Content-Language: en-US To: Alexandru Elisei , catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com Cc: pcc@google.com, steven.price@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org References: <20240125164256.4147-1-alexandru.elisei@arm.com> <20240125164256.4147-8-alexandru.elisei@arm.com> From: Anshuman Khandual In-Reply-To: <20240125164256.4147-8-alexandru.elisei@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: zoy5zd44sdeya653p6pc3xg18nhctqrp X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6A1A3160003 X-HE-Tag: 1706520699-243376 X-HE-Meta: U2FsdGVkX1+BySnQ60PkAkEUDJXk3PrkhNWtvRhe+sF0eWz9dnLnnhqjS/BV8qpK5CIDYYCGG+gYi5cezYSQdfGqyHWb5gLJ37sZ6Sl6MfzkhIN5NoNXuy1/yAmWFiYr6ZGh/MhchqvGC4m7WOumoXdss2cYuMIXu2A7JWUAus5midEt9h4HhoNOs81Bkitc+k86Iq8uRGf0CgCwUjfXxXcNTF+Wc4l4fhUE+UTrqzC2jtGDs/CoNP2Cmp0O1K15ALy6N+0b84UDvNabVhGmYb331RXFv8/wmZjGjvdtWYpHGLJGcEhR0v/ykM0CPsfNIDMIe8lTbsNlSy1QKehOKI9kZQlpRyyfZG/9PMbSiZZNiXiRnU4/wLoz6M2jrH63Agxzi0xFJKpYTiE0tJKZggopQWtpdtpiQZhWTjRHu9hQhB4WVq4OgHZyvYwJKwM1y1fdiWs1b+10jfRUvGFx72YrHy7xOx3qswgfDZuOb8pOJcPlrLKUdPtWm5vR/Lsh10OWsob/NPh5TrPda7bHAqbxl475ThrDoP07UXLTALU5pXtUnJbF4JoiAnBJSK1Xc8vq4Hzm5GWOz662XdHgLx88ZSSVrM93pv/yxwn+7jqCGQ2dmxjQpGUCZRmomgpcFLsSIM5pk7rgtRBQyMEUh9LUux/OsQpxYhKeSzcL0rptb1cm7Yg7Q+tWYGKkfjAUpWkU9NM+/ZK3oIRGkvCinXASj/KmmA4bS1Otsin4tQwSELg3g24F5c7o5kFZ+EeKlw4jpGeb1HQuk/Vr6P0HzdDHZItU2HNHKIJzV01hM9zubkUwRLSz5IVDgD3JAp+/abiQteL2ue9abzy95UDRGkiKUABW2EaJoI5x6vqYQYLQNeE7Go4McGdgr9yB7In8lPW/eqbdkVI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/25/24 22:12, Alexandru Elisei wrote: > Similar to the two events that relate to CMA allocations, add the > CMA_RELEASE_SUCCESS and CMA_RELEASE_FAIL events that count when CMA pages > are freed. How is this is going to be beneficial towards analyzing CMA alloc/release behaviour - particularly with respect to this series. OR just adding this from parity perspective with CMA alloc side counters ? Regardless this CMA change too could be discussed separately. > > Signed-off-by: Alexandru Elisei > --- > > Changes since rfc v2: > > * New patch. > > include/linux/vm_event_item.h | 2 ++ > mm/cma.c | 6 +++++- > mm/vmstat.c | 2 ++ > 3 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h > index 747943bc8cc2..aba5c5bf8127 100644 > --- a/include/linux/vm_event_item.h > +++ b/include/linux/vm_event_item.h > @@ -83,6 +83,8 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, > #ifdef CONFIG_CMA > CMA_ALLOC_SUCCESS, > CMA_ALLOC_FAIL, > + CMA_RELEASE_SUCCESS, > + CMA_RELEASE_FAIL, > #endif > UNEVICTABLE_PGCULLED, /* culled to noreclaim list */ > UNEVICTABLE_PGSCANNED, /* scanned for reclaimability */ > diff --git a/mm/cma.c b/mm/cma.c > index dbf7fe8cb1bd..543bb6b3be8e 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -562,8 +562,10 @@ bool cma_release(struct cma *cma, const struct page *pages, > { > unsigned long pfn; > > - if (!cma_pages_valid(cma, pages, count)) > + if (!cma_pages_valid(cma, pages, count)) { > + count_vm_events(CMA_RELEASE_FAIL, count); > return false; > + } > > pr_debug("%s(page %p, count %lu)\n", __func__, (void *)pages, count); > > @@ -575,6 +577,8 @@ bool cma_release(struct cma *cma, const struct page *pages, > cma_clear_bitmap(cma, pfn, count); > trace_cma_release(cma->name, pfn, pages, count); > > + count_vm_events(CMA_RELEASE_SUCCESS, count); > + > return true; > } > > diff --git a/mm/vmstat.c b/mm/vmstat.c > index db79935e4a54..eebfd5c6c723 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -1340,6 +1340,8 @@ const char * const vmstat_text[] = { > #ifdef CONFIG_CMA > "cma_alloc_success", > "cma_alloc_fail", > + "cma_release_success", > + "cma_release_fail", > #endif > "unevictable_pgs_culled", > "unevictable_pgs_scanned",