From: Vlastimil Babka <vbabka@suse.cz>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Mel Gorman <mgorman@suse.de>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mm/compaction: enhance trace output to know more about compaction internals
Date: Tue, 06 Jan 2015 10:05:39 +0100 [thread overview]
Message-ID: <54ABA563.1040103@suse.cz> (raw)
In-Reply-To: <1417593127-6819-1-git-send-email-iamjoonsoo.kim@lge.com>
On 12/03/2014 08:52 AM, Joonsoo Kim wrote:
> It'd be useful to know where the both scanner is start. And, it also be
> useful to know current range where compaction work. It will help to find
> odd behaviour or problem on compaction.
Overall it looks good, just two questions:
1) Why change the pfn output to hexadecimal with different printf layout and
change the variable names and? Is it that better to warrant people having to
potentially modify their scripts parsing the old output?
2) Would it be useful to also print in the mm_compaction_isolate_template based
tracepoints, pfn of where the particular scanner left off a block prematurely?
It doesn't always match start_pfn + nr_scanned.
Thanks,
Vlastimil
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-01-06 9:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 7:52 [PATCH 1/3] mm/compaction: enhance trace output to know more about compaction internals Joonsoo Kim
2014-12-03 7:52 ` [PATCH 2/3] mm/compaction: add more trace to understand compaction start/finish condition Joonsoo Kim
2015-01-06 11:04 ` Vlastimil Babka
2015-01-08 8:21 ` Joonsoo Kim
2015-01-08 8:47 ` Vlastimil Babka
2014-12-03 7:52 ` [PATCH 3/3] mm/compaction: add tracepoint to observe behaviour of compaction defer Joonsoo Kim
2015-01-06 11:27 ` Vlastimil Babka
2015-01-08 8:23 ` Joonsoo Kim
2015-01-05 2:33 ` [PATCH 1/3] mm/compaction: enhance trace output to know more about compaction internals Joonsoo Kim
2015-01-05 8:58 ` Vlastimil Babka
2015-01-06 9:05 ` Vlastimil Babka [this message]
2015-01-08 8:18 ` Joonsoo Kim
2015-01-08 8:46 ` Vlastimil Babka
2015-01-09 1:04 ` Joonsoo Kim
2015-01-09 10:57 ` Mel Gorman
2015-01-12 8:20 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54ABA563.1040103@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).