From: Vlastimil Babka <vbabka@suse.cz>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
Johannes Weiner <hannes@cmpxchg.org>,
Vladimir Davydov <vdavydov@parallels.com>,
Rik van Riel <riel@redhat.com>, Michal Hocko <mhocko@suse.cz>,
Mel Gorman <mgorman@suse.de>,
Suleiman Souhlal <suleiman@google.com>,
linux-mm@kvack.org
Subject: Re: [PATCH] mm/vmscan: fix highidx argument type
Date: Fri, 16 Jan 2015 20:02:06 +0100 [thread overview]
Message-ID: <54B9602E.70707@suse.cz> (raw)
In-Reply-To: <54B95E41.5010305@suse.cz>
On 01/16/2015 07:53 PM, Vlastimil Babka wrote:
> BTW, I wonder if the whole code couldn't be much simpler by capping high_zoneidx
> by ZONE_NORMAL before traversing the zonelist, like this:
>
> int high_zoneidx = min(gfp_zone(gfp_mask), ZONE_NORMAL);
>
> first_zones_zonelist(zonelist, high_zoneidx, NULL, &zone);
Erm, s/NULL/nodemask/ here. I copy/pasted this from before 675becce15f32, where
it didn't actually use the nodemask parameter of throttle_direct_reclaim(),
Wonder why, looks like another bug to me, that the commit has silently fixed.
> pgdat = zone->zone_pgdat;
>
> if (!pgdat || pfmemalloc_watermark_ok(pgdat))
> goto out;
>
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2015-01-16 19:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 22:18 [PATCH] mm/vmscan: fix highidx argument type Michael S. Tsirkin
2015-01-15 22:49 ` Andrew Morton
2015-01-16 7:07 ` Michael S. Tsirkin
2015-01-16 18:53 ` Vlastimil Babka
2015-01-16 19:02 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B9602E.70707@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=mst@redhat.com \
--cc=riel@redhat.com \
--cc=suleiman@google.com \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).