From: Greg Ungerer <gerg@uclinux.org>
To: Arnd Bergmann <arnd@arndb.de>, Andrew Morton <akpm@linux-foundation.org>
Cc: kirill.shutemov@linux.intel.com, linux-mm@kvack.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mm: export "high_memory" symbol on !MMU
Date: Thu, 29 Jan 2015 11:15:34 +1000 [thread overview]
Message-ID: <54C989B6.4080006@uclinux.org> (raw)
In-Reply-To: <2715923.qFZi90ffep@wuerfel>
On 29/01/15 00:43, Arnd Bergmann wrote:
>>From f391eb37fafc8a22d7fd9574b8d220f0d90a91d0 Mon Sep 17 00:00:00 2001
> From: Arnd Bergmann <arnd@arndb.de>
> Date: Mon, 25 Aug 2014 16:24:41 +0200
> Subject: [PATCH] mm: export "high_memory" symbol on !MMU
>
> The symbol 'high_memory' is provided on both MMU- and NOMMU-kernels,
> but only one of them is exported, which leads to module build errors
> in drivers that work fine built-in:
>
> ERROR: "high_memory" [drivers/net/virtio_net.ko] undefined!
> ERROR: "high_memory" [drivers/net/ppp/ppp_mppe.ko] undefined!
> ERROR: "high_memory" [drivers/mtd/nand/nand.ko] undefined!
> ERROR: "high_memory" [crypto/tcrypt.ko] undefined!
> ERROR: "high_memory" [crypto/cts.ko] undefined!
>
> This exports the symbol to get these to work on NOMMU as well.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Here is an ack if you want one:
Acked-by: Greg Ungerer <gerg@uclinux.org>
Regards
Greg
> diff --git a/mm/nommu.c b/mm/nommu.c
> index e9228cbe46de..7bdeb281ad0e 100644
> --- a/mm/nommu.c
> +++ b/mm/nommu.c
> @@ -59,6 +59,7 @@
> #endif
>
> void *high_memory;
> +EXPORT_SYMBOL(high_memory);
> struct page *mem_map;
> unsigned long max_mapnr;
> unsigned long highest_memmap_pfn;
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-01-29 1:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 14:43 [PATCH] mm: export "high_memory" symbol on !MMU Arnd Bergmann
2015-01-29 1:15 ` Greg Ungerer [this message]
2015-02-02 17:51 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C989B6.4080006@uclinux.org \
--to=gerg@uclinux.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).