From: Mike Kravetz <mike.kravetz@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Nadia Yvette Chambers <nyc@holomorphy.com>,
Aneesh Kumar <aneesh.kumar@linux.vnet.ibm.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [RFC 3/3] hugetlbfs: accept subpool reserved option and setup accordingly
Date: Mon, 02 Mar 2015 17:36:47 -0800 [thread overview]
Message-ID: <54F5102F.50902@oracle.com> (raw)
In-Reply-To: <20150302151033.562db79cd3da844392461795@linux-foundation.org>
On 03/02/2015 03:10 PM, Andrew Morton wrote:
> On Fri, 27 Feb 2015 14:58:13 -0800 Mike Kravetz <mike.kravetz@oracle.com> wrote:
>
>> Make reserved be an option when mounting a hugetlbfs.
>
> New mount option triggers a user documentation update. hugetlbfs isn't
> well documented, but Documentation/vm/hugetlbpage.txt looks like the
> place.
>
Will do
>
>> reserved
>> option is only possible if size option is also specified.
>
> The code doesn't appear to check for this (maybe it does). Probably it
> should do so, and warn when it fails.
>
It is hard to see from the diffs, but this case is covered. If size is
not specified, it implies the size is "unlimited". The code in the
patch actually makes the mount fail in this case.
--
Mike Kravetz
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-03-03 1:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 22:58 [RFC 0/3] hugetlbfs: optionally reserve all fs pages at mount time Mike Kravetz
2015-02-27 22:58 ` [RFC 1/3] hugetlbfs: add reserved mount fields to subpool structure Mike Kravetz
2015-02-27 22:58 ` Mike Kravetz
2015-03-02 23:10 ` Andrew Morton
2015-03-03 1:20 ` Mike Kravetz
2015-02-27 22:58 ` [RFC 2/3] hugetlbfs: coordinate global and subpool reserve accounting Mike Kravetz
2015-03-02 23:10 ` Andrew Morton
2015-03-03 1:30 ` Mike Kravetz
2015-02-27 22:58 ` Mike Kravetz
2015-02-27 22:58 ` [RFC 3/3] hugetlbfs: accept subpool reserved option and setup accordingly Mike Kravetz
2015-03-02 23:10 ` Andrew Morton
2015-03-03 1:36 ` Mike Kravetz [this message]
2015-03-02 23:10 ` [RFC 0/3] hugetlbfs: optionally reserve all fs pages at mount time Andrew Morton
2015-03-03 1:18 ` Mike Kravetz
2015-03-06 15:10 ` Michal Hocko
2015-03-06 18:58 ` Mike Kravetz
2015-03-06 21:14 ` David Rientjes
2015-03-06 21:32 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F5102F.50902@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nyc@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).