From: Rik van Riel <riel@redhat.com>
To: Laura Abbott <lauraa@codeaurora.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Vlastimil Babka <vbabka@suse.cz>, Gioh Kim <gioh.kim@lge.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Mel Gorman <mgorman@suse.de>,
Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
Zhang Yanfei <zhangyanfei@cn.fujitsu.com>,
Xishi Qiu <qiuxishi@huawei.com>,
Vladimir Davydov <vdavydov@parallels.com>,
Michal Nazarewicz <mina86@mina86.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] mm/page_alloc: Call kernel_map_pages in unset_migrateype_isolate
Date: Mon, 16 Mar 2015 22:23:01 -0400 [thread overview]
Message-ID: <55079005.9000307@redhat.com> (raw)
In-Reply-To: <1426530585-11367-1-git-send-email-lauraa@codeaurora.org>
On 03/16/2015 02:29 PM, Laura Abbott wrote:
> Commit 3c605096d315 ("mm/page_alloc: restrict max order of merging on isolated pageblock")
> changed the logic of unset_migratetype_isolate to check the buddy allocator
> and explicitly call __free_pages to merge. The page that is being freed in
> this path never had prep_new_page called so set_page_refcounted is called
> explicitly but there is no call to kernel_map_pages. With the default
> kernel_map_pages this is mostly harmless but if kernel_map_pages does any
> manipulation of the page tables (unmapping or setting pages to read only) this
> may trigger a fault:
>
> alloc_contig_range test_pages_isolated(ceb00, ced00) failed
> Unable to handle kernel paging request at virtual address ffffffc0cec00000
> pgd = ffffffc045fc4000
> [ffffffc0cec00000] *pgd=0000000000000000
> Internal error: Oops: 9600004f [#1] PREEMPT SMP
> Modules linked in: exfatfs
> CPU: 1 PID: 23237 Comm: TimedEventQueue Not tainted 3.10.49-gc72ad36-dirty #1
> task: ffffffc03de52100 ti: ffffffc015388000 task.ti: ffffffc015388000
> PC is at memset+0xc8/0x1c0
> LR is at kernel_map_pages+0x1ec/0x244
>
> Fix this by calling kernel_map_pages to ensure the page is set in the
> page table properly
Acked-by: Rik van Riel <riel@redhat.com>
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2015-03-17 2:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 18:29 [PATCH] mm/page_alloc: Call kernel_map_pages in unset_migrateype_isolate Laura Abbott
2015-03-17 2:08 ` Joonsoo Kim
2015-03-17 2:23 ` Rik van Riel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55079005.9000307@redhat.com \
--to=riel@redhat.com \
--cc=gioh.kim@lge.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=lauraa@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
--cc=mgorman@suse.de \
--cc=mina86@mina86.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=qiuxishi@huawei.com \
--cc=vbabka@suse.cz \
--cc=vdavydov@parallels.com \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).