From: David Vrabel <david.vrabel@citrix.com>
To: Daniel Kiper <daniel.kiper@oracle.com>,
David Vrabel <david.vrabel@citrix.com>
Cc: linux-mm@kvack.org, xen-devel@lists.xenproject.org,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
linux-kernel@vger.kernel.org
Subject: Re: [Xen-devel] [PATCHv1 5/8] xen/balloon: rationalize memory hotplug stats
Date: Fri, 26 Jun 2015 09:59:04 +0100 [thread overview]
Message-ID: <558D1458.1000300@citrix.com> (raw)
In-Reply-To: <20150625213113.GP14050@olila.local.net-space.pl>
On 25/06/15 22:31, Daniel Kiper wrote:
> On Thu, Jun 25, 2015 at 08:54:45PM +0200, Daniel Kiper wrote:
>
> It looks that balloon_stats.total_pages is used only in memory hotplug case.
> Please do references (and definition) to it inside #ifdef CONFIG_XEN_BALLOON_MEMORY_HOTPLUG
> like it is done in balloon_stats.hotplug_pages and balloon_stats.balloon_hotplug case.
I don't think the space saving here really warrants sprinkling a bunch
of #ifdefs around.
David
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-06-26 8:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 17:10 [PATCHv1 0/8] mm,xen/balloon: memory hotplug improvements David Vrabel
2015-06-25 17:10 ` [PATCHv1 1/8] mm: memory hotplug with an existing resource David Vrabel
2015-06-25 18:01 ` Daniel Kiper
2015-06-25 17:10 ` [PATCHv1 2/8] xen/balloon: remove scratch page left overs David Vrabel
2015-06-25 18:01 ` Daniel Kiper
2015-06-25 17:10 ` [PATCHv1 3/8] x86/xen: discard RAM regions above the maximum reservation David Vrabel
2015-06-25 18:03 ` Daniel Kiper
2015-06-25 17:10 ` [PATCHv1 4/8] xen/balloon: find non-conflicting regions to place hotplugged memory David Vrabel
2015-06-25 18:16 ` Daniel Kiper
2015-06-25 17:11 ` [PATCHv1 5/8] xen/balloon: rationalize memory hotplug stats David Vrabel
2015-06-25 18:38 ` Daniel Kiper
2015-06-25 18:54 ` Daniel Kiper
2015-06-25 21:31 ` Daniel Kiper
2015-06-26 8:59 ` David Vrabel [this message]
2015-06-25 17:11 ` [PATCHv1 6/8] xen/balloon: only hotplug additional memory if required David Vrabel
2015-06-25 21:18 ` Daniel Kiper
2015-06-26 8:56 ` [Xen-devel] " David Vrabel
2015-06-26 12:46 ` Daniel Kiper
2015-06-26 13:14 ` David Vrabel
2015-06-25 17:11 ` [PATCHv1 7/8] xen/balloon: make alloc_xenballoon_pages() always allocate low pages David Vrabel
2015-06-25 21:36 ` Daniel Kiper
2015-06-25 17:11 ` [PATCHv1 8/8] xen/balloon: use hotplugged pages for foreign mappings etc David Vrabel
2015-06-25 21:49 ` Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558D1458.1000300@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=daniel.kiper@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).