From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yk0-f170.google.com (mail-yk0-f170.google.com [209.85.160.170]) by kanga.kvack.org (Postfix) with ESMTP id 8EFF06B0038 for ; Fri, 26 Jun 2015 17:34:31 -0400 (EDT) Received: by ykdy1 with SMTP id y1so70146690ykd.2 for ; Fri, 26 Jun 2015 14:34:31 -0700 (PDT) Received: from aserp1040.oracle.com (aserp1040.oracle.com. [141.146.126.69]) by mx.google.com with ESMTPS id q66si13843643ywe.209.2015.06.26.14.34.28 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Jun 2015 14:34:29 -0700 (PDT) Message-ID: <558DC55D.3000804@oracle.com> Date: Fri, 26 Jun 2015 17:34:21 -0400 From: Sasha Levin MIME-Version: 1.0 Subject: Re: [PATCH 00/11] mm: debug: formatting memory management structs References: <1431623414-1905-1-git-send-email-sasha.levin@oracle.com> In-Reply-To: <1431623414-1905-1-git-send-email-sasha.levin@oracle.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: linux-mm@kvack.org Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, kirill@shutemov.name There were no objections beyond Andrew's request for a better changelog. If there are no any further objections, can it be merged please? On 05/14/2015 01:10 PM, Sasha Levin wrote: > This patch series adds knowledge about various memory management structures > to the standard print functions. > > In essence, it allows us to easily print those structures: > > printk("%pZp %pZm %pZv", page, mm, vma); > > This allows us to customize output when hitting bugs even further, thus > we introduce VM_BUG() which allows printing anything when hitting a bug > rather than just a single piece of information. > > This also means we can get rid of VM_BUG_ON_* since they're now nothing > more than a format string. > > Changes since RFC: > - Address comments by Kirill. > > Sasha Levin (11): > mm: debug: format flags in a buffer > mm: debug: deal with a new family of MM pointers > mm: debug: dump VMA into a string rather than directly on screen > mm: debug: dump struct MM into a string rather than directly on > screen > mm: debug: dump page into a string rather than directly on screen > mm: debug: clean unused code > mm: debug: VM_BUG() > mm: debug: kill VM_BUG_ON_PAGE > mm: debug: kill VM_BUG_ON_VMA > mm: debug: kill VM_BUG_ON_MM > mm: debug: use VM_BUG() to help with debug output > > arch/arm/mm/mmap.c | 2 +- > arch/frv/mm/elf-fdpic.c | 4 +- > arch/mips/mm/gup.c | 4 +- > arch/parisc/kernel/sys_parisc.c | 2 +- > arch/powerpc/mm/hugetlbpage.c | 2 +- > arch/powerpc/mm/pgtable_64.c | 4 +- > arch/s390/mm/gup.c | 2 +- > arch/s390/mm/mmap.c | 2 +- > arch/s390/mm/pgtable.c | 6 +-- > arch/sh/mm/mmap.c | 2 +- > arch/sparc/kernel/sys_sparc_64.c | 4 +- > arch/sparc/mm/gup.c | 2 +- > arch/sparc/mm/hugetlbpage.c | 4 +- > arch/tile/mm/hugetlbpage.c | 2 +- > arch/x86/kernel/sys_x86_64.c | 2 +- > arch/x86/mm/gup.c | 8 ++-- > arch/x86/mm/hugetlbpage.c | 2 +- > arch/x86/mm/pgtable.c | 6 +-- > include/linux/huge_mm.h | 2 +- > include/linux/hugetlb.h | 2 +- > include/linux/hugetlb_cgroup.h | 4 +- > include/linux/mm.h | 22 ++++----- > include/linux/mmdebug.h | 40 ++++++---------- > include/linux/page-flags.h | 26 +++++----- > include/linux/pagemap.h | 11 +++-- > include/linux/rmap.h | 2 +- > kernel/fork.c | 2 +- > lib/vsprintf.c | 22 +++++++++ > mm/balloon_compaction.c | 4 +- > mm/cleancache.c | 6 +-- > mm/compaction.c | 2 +- > mm/debug.c | 98 ++++++++++++++++++++------------------ > mm/filemap.c | 18 +++---- > mm/gup.c | 12 ++--- > mm/huge_memory.c | 50 +++++++++---------- > mm/hugetlb.c | 28 +++++------ > mm/hugetlb_cgroup.c | 2 +- > mm/internal.h | 8 ++-- > mm/interval_tree.c | 2 +- > mm/kasan/report.c | 2 +- > mm/ksm.c | 13 ++--- > mm/memcontrol.c | 48 +++++++++---------- > mm/memory.c | 10 ++-- > mm/memory_hotplug.c | 2 +- > mm/migrate.c | 6 +-- > mm/mlock.c | 4 +- > mm/mmap.c | 15 +++--- > mm/mremap.c | 4 +- > mm/page_alloc.c | 28 +++++------ > mm/page_io.c | 4 +- > mm/pagewalk.c | 2 +- > mm/pgtable-generic.c | 8 ++-- > mm/rmap.c | 20 ++++---- > mm/shmem.c | 10 ++-- > mm/slub.c | 4 +- > mm/swap.c | 39 +++++++-------- > mm/swap_state.c | 16 +++---- > mm/swapfile.c | 8 ++-- > mm/vmscan.c | 24 +++++----- > 59 files changed, 355 insertions(+), 335 deletions(-) > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org