From: Dave Hansen <dave.hansen@intel.com>
To: Xishi Qiu <qiuxishi@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>, Vlastimil Babka <vbabka@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>,
iamjoonsoo.kim@lge.com, alexander.h.duyck@redhat.com,
sasha.levin@oracle.com, Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: add the block to the tail of the list in expand()
Date: Sun, 02 Aug 2015 21:10:06 -0700 [thread overview]
Message-ID: <55BEE99E.8090901@intel.com> (raw)
In-Reply-To: <55BECC85.7050206@huawei.com>
On 08/02/2015 07:05 PM, Xishi Qiu wrote:
>> > Also, this might not do very much good in practice. If you are
>> > splitting a high-order page, you are doing the split because the
>> > lower-order lists are empty. So won't that list_add() be to an empty
>
> I made a mistake, you are right, all the lower-order lists are empty,
> so it is no sense to add to the tail.
I actually tested this experimentally and the lists are not always
empty. It's probably __rmqueue_smallest() vs. __rmqueue_fallback() logic.
In any case, you might want to double-check.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-08-03 4:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 9:30 [PATCH] mm: add the block to the tail of the list in expand() Xishi Qiu
2015-07-31 23:24 ` Dave Hansen
2015-08-03 2:05 ` Xishi Qiu
2015-08-03 4:10 ` Dave Hansen [this message]
2015-08-04 1:13 ` Xishi Qiu
2015-08-04 14:27 ` Dave Hansen
2015-08-05 7:54 ` Xishi Qiu
2015-08-05 14:47 ` Dave Hansen
2015-08-14 7:55 ` Xishi Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BEE99E.8090901@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=qiuxishi@huawei.com \
--cc=sasha.levin@oracle.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).