From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD13EC433F5 for ; Fri, 13 May 2022 12:03:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 542FF6B0073; Fri, 13 May 2022 08:03:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CAF76B0075; Fri, 13 May 2022 08:03:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 345B06B0078; Fri, 13 May 2022 08:03:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 23D946B0073 for ; Fri, 13 May 2022 08:03:13 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E9504213C6 for ; Fri, 13 May 2022 12:03:12 +0000 (UTC) X-FDA: 79460584224.17.9161966 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id CDFBD1000B1 for ; Fri, 13 May 2022 12:03:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652443391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=InGhDMkcup0GagnASVzgx+dKX2knJzd1xQg5+9fN/y4=; b=PvoRaUmp6VwZf9xb7R2ECWfuBUD9rruivi/DkXLe9R1V6VkCWZ5LsVJqZYSD2JKhODSG+P WJvNb87LAavHnUbidtLJluDQbN2vMJX2H0QoIP9bLlxTpL9aTbqpbe/hY8dgaJ2R1KZfgP Q2I/xk41bxzpRuIDTCR+HPk1FLqwTTI= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-208-NQkk56wHMdWL-IEa7eBhfA-1; Fri, 13 May 2022 08:03:10 -0400 X-MC-Unique: NQkk56wHMdWL-IEa7eBhfA-1 Received: by mail-wr1-f69.google.com with SMTP id s14-20020adfa28e000000b0020ac7532f08so2861761wra.15 for ; Fri, 13 May 2022 05:03:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=InGhDMkcup0GagnASVzgx+dKX2knJzd1xQg5+9fN/y4=; b=uBIQSiqloA6sbR7qIamzq22/dSeVOa+QihesuC4QZGlHET0NBYcsWM55TtosCGzecy klB8OqI2ZwgoDtrBMeEJTdOs536W6nNO/VE2YJMnREiLjDSfKtSTnwbaBxD0qTU3orI3 br4WxxX4AHMLPjtFvgZMJ2foUsLHsfqV8NuxgLj51caIVDbrxuOYFVIClsscMG/XFLF9 4Lh9cH9z6zLB/vVfEG8vo/7DhJAbErcy03GaW8SfJWq1DtEaNoVLft+rnE4BWNKZaIOC fYxitIUVDCL9fQi3OTA7ay7DPeJ8/bMKVuCS326fIOZ+T5RMaDWbAD6JC4gSM3kdm+q1 vwwg== X-Gm-Message-State: AOAM533v26riwCKfcv5Dbbn9giV93IZvnAhkES8pnlH4okrPuyCKaUEw FB4VjXAQGBf09RUzoTbLwnf8n1LTPQ6KvMFZnwLSZqiKb94SE9XYZweB3/3wIZP3U4jqzVo5jYm +R8ky+9cXEco= X-Received: by 2002:adf:e94d:0:b0:20c:d4d3:c696 with SMTP id m13-20020adfe94d000000b0020cd4d3c696mr3731605wrn.136.1652443389468; Fri, 13 May 2022 05:03:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzi5XYqp/fTB48DqoJAA1/Ye79XxuoHvTUDaKgK304p8SKf1INMxAgcZ+nWWo/NwbkFCpqHCw== X-Received: by 2002:adf:e94d:0:b0:20c:d4d3:c696 with SMTP id m13-20020adfe94d000000b0020cd4d3c696mr3731585wrn.136.1652443389232; Fri, 13 May 2022 05:03:09 -0700 (PDT) Received: from ?IPv6:2a0c:5a80:1306:2f00:be0e:91f7:c0a3:32f0? ([2a0c:5a80:1306:2f00:be0e:91f7:c0a3:32f0]) by smtp.gmail.com with ESMTPSA id l12-20020adfbd8c000000b0020c547f75easm1940208wrh.101.2022.05.13.05.03.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 05:03:08 -0700 (PDT) Message-ID: <55aaf618497e7d0d369f773723b12e5dcfbdd27d.camel@redhat.com> Subject: Re: [PATCH 4/6] mm/page_alloc: Remove unnecessary page == NULL check in rmqueue From: Nicolas Saenz Julienne To: Mel Gorman , Andrew Morton Cc: Marcelo Tosatti , Vlastimil Babka , Michal Hocko , LKML , Linux-MM Date: Fri, 13 May 2022 14:03:08 +0200 In-Reply-To: <20220512085043.5234-5-mgorman@techsingularity.net> References: <20220512085043.5234-1-mgorman@techsingularity.net> <20220512085043.5234-5-mgorman@techsingularity.net> User-Agent: Evolution 3.44.1 (3.44.1-1.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: CDFBD1000B1 X-Stat-Signature: py4ae1yabikpxezatsejimexjn8xpc47 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PvoRaUmp; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf14.hostedemail.com: domain of nsaenzju@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=nsaenzju@redhat.com X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1652443389-951372 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 2022-05-12 at 09:50 +0100, Mel Gorman wrote: > The VM_BUG_ON check for a valid page can be avoided with a simple > change in the flow. The ZONE_BOOSTED_WATERMARK is unlikely in general > and even more unlikely if the page allocation failed so mark the > branch unlikely. >=20 > Signed-off-by: Mel Gorman > Tested-by: Minchan Kim > Acked-by: Minchan Kim > --- Reviewed-by: Nicolas Saenz Julienne Thanks, --=20 Nicol=C3=A1s S=C3=A1enz