Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Qi Zheng <qi.zheng@linux.dev>
To: Muchun Song <songmuchun@bytedance.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Hildenbrand <david@kernel.org>,
	Oscar Salvador <osalvador@suse.de>,
	Madhavan Srinivasan <maddy@linux.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Jonathan Corbet <corbet@lwn.net>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-doc@vger.kernel.org,
	Muchun Song <muchun.song@linux.dev>,
	Lorenzo Stoakes <ljs@kernel.org>, Mike Rapoport <rppt@kernel.org>,
	Nicholas Piggin <npiggin@gmail.com>,
	Christophe Leroy <chleroy@kernel.org>,
	Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH 03/11] mm/sparse-vmemmap: open-code init_compound_tail()
Date: Tue, 1 Sep 2026 11:18:09 +0800	[thread overview]
Message-ID: <56119ff9-26f2-450c-bff9-8a4169027ba9@linux.dev> (raw)
In-Reply-To: <20260831075342.57563-4-songmuchun@bytedance.com>



On 8/31/26 3:53 PM, Muchun Song wrote:
> init_compound_tail() is only used by vmemmap_shared_tail_page(), where
> the shared tail page setup intentionally passes NULL as the compound head.
> 
> Keeping this helper in mm/internal.h exposes that special case to the rest
> of the MM code and can make the NULL head argument look generally valid.
> Open-code the initialization at the only call site so the special-case use
> stays local to sparse vmemmap optimization.
> 
> No functional change intended.
> 
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---
>   mm/internal.h       | 9 ---------
>   mm/sparse-vmemmap.c | 5 ++++-
>   2 files changed, 4 insertions(+), 10 deletions(-)
> 

Acked-by: Qi Zheng <qi.zheng@linux.dev>

Thanks,
Qi




  reply	other threads:[~2026-09-01  3:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-31  7:53 [PATCH 00/11] mm: Switch device DAX to section-based vmemmap optimization Muchun Song
2026-08-31  7:53 ` [PATCH 01/11] mm/sparse-vmemmap: introduce CONFIG_SPARSEMEM_VMEMMAP_OPTIMIZATION Muchun Song
2026-08-31  9:44   ` Qi Zheng
2026-08-31  9:49     ` Muchun Song
2026-08-31  7:53 ` [PATCH 02/11] mm/sparse-vmemmap: factor out shared vmemmap tail page allocation Muchun Song
2026-09-01  3:05   ` Qi Zheng
2026-08-31  7:53 ` [PATCH 03/11] mm/sparse-vmemmap: open-code init_compound_tail() Muchun Song
2026-09-01  3:18   ` Qi Zheng [this message]
2026-08-31  7:53 ` [PATCH 04/11] mm/sparse-vmemmap: prepare DAX vmemmap population for section orders Muchun Song
2026-09-03  6:36   ` Qi Zheng
2026-08-31  7:53 ` [PATCH 05/11] mm/sparse-vmemmap: set section order for device DAX Muchun Song
2026-08-31  7:53 ` [PATCH 06/11] mm/sparse-vmemmap: switch device DAX to shared tail vmemmap pages Muchun Song
2026-08-31  7:53 ` [PATCH 07/11] mm/sparse-vmemmap: move HVO helpers to a public header Muchun Song
2026-08-31  7:53 ` [PATCH 08/11] powerpc/mm: switch device DAX to shared tail vmemmap pages Muchun Song
2026-08-31  7:53 ` [PATCH 09/11] mm/sparse-vmemmap: drop the extra tail page from device DAX reservation Muchun Song
2026-08-31  7:53 ` [PATCH 10/11] mm/sparse-vmemmap: drop unused section_nr_vmemmap_pages() arguments Muchun Song
2026-08-31  7:53 ` [PATCH 11/11] Documentation/mm: update DAX vmemmap deduplication docs Muchun Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56119ff9-26f2-450c-bff9-8a4169027ba9@linux.dev \
    --to=qi.zheng@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=chleroy@kernel.org \
    --cc=corbet@lwn.net \
    --cc=david@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=ljs@kernel.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=muchun.song@linux.dev \
    --cc=npiggin@gmail.com \
    --cc=osalvador@suse.de \
    --cc=rdunlap@infradead.org \
    --cc=rppt@kernel.org \
    --cc=songmuchun@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox