From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CBA8C05027 for ; Mon, 20 Feb 2023 08:29:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B5C16B0071; Mon, 20 Feb 2023 03:29:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 864E96B0072; Mon, 20 Feb 2023 03:29:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7539E6B0073; Mon, 20 Feb 2023 03:29:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 67E3D6B0071 for ; Mon, 20 Feb 2023 03:29:13 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3282D120F0C for ; Mon, 20 Feb 2023 08:29:13 +0000 (UTC) X-FDA: 80486995386.30.1DF564E Received: from mx1.emlix.com (mx1.emlix.com [136.243.223.33]) by imf19.hostedemail.com (Postfix) with ESMTP id 1330C1A0002 for ; Mon, 20 Feb 2023 08:29:10 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of eb@emlix.com designates 136.243.223.33 as permitted sender) smtp.mailfrom=eb@emlix.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676881751; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yonoHScxZ9dz45c4/NSfy0pliYKltAJxcACoCQgqPSY=; b=gVGCJvtjVdPORb5Vxyj479/v1J3zcvm9s+vOI0C+UIMDfopP8On4hRR+VZxv0IFyP2J0nr D0rspGcJNG/WNmixnPRvO9danfugYaArdr26eHjeufwfDAJsDPkPwC6IOIfECw9NIHEfj+ rajI1QTnubdEgKL+jrxuhojiLF6ecdk= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of eb@emlix.com designates 136.243.223.33 as permitted sender) smtp.mailfrom=eb@emlix.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676881751; a=rsa-sha256; cv=none; b=wMW+HYISbdCP7Gvf5yWgEe/FZTuQGrg/8/M1gJjhR3PTxdC4p/gKaYZ1mhtScRlN4PLlUz TQ+YYPXOiT/lRWHPdvpUfvZ6xJ2TLTsyfWjx1eP0BZjtblKxtRhsEyKhFkVVm0CagmYeHL BxXMjlkAm/Q5LW9ppiRXT5SbHWwfPQU= Received: from mailer.emlix.com (unknown [81.20.119.6]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.emlix.com (Postfix) with ESMTPS id 167505F997; Mon, 20 Feb 2023 09:29:09 +0100 (CET) From: Rolf Eike Beer To: Matthew Wilcox , linux-arch@vger.kernel.org, Alexandre Ghiti Cc: Yin Fengwei , linux-mm@kvack.org, linux-alpha@vger.kernel.org, linux-csky@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, Dinh Nguyen , linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, openrisc@lists.librecores.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org Subject: Re: API for setting multiple PTEs at once Date: Mon, 20 Feb 2023 09:29:58 +0100 Message-ID: <5649318.DvuYhMxLoT@devpool47> Organization: emlix GmbH In-Reply-To: <0bf59207-838b-2a0b-a95e-925a6bbf1913@ghiti.fr> References: <0bf59207-838b-2a0b-a95e-925a6bbf1913@ghiti.fr> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart5907765.lOV4Wx5bFT"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1330C1A0002 X-Stat-Signature: s4baptnxwqutju9g1hrp7axyws6mmyix X-Rspam-User: X-HE-Tag: 1676881750-424405 X-HE-Meta: U2FsdGVkX1/G9leg/eDNDfpulLUxtUQ+vNgygC+ACCqQSmSxlvP4O8J7XO4ihxLW850VSs1+4hrWm/8CcTW/mQMtVXtKuQGqPe3jbMwa+8oH8YlL4bwhZvwwWIgYIS03R2H6A2v5y2StSq3KxFtS0UxZd6bOE1ZdldJ9TFJCvm0w6+yVwR9PEWV/FLk/ja3HM4BIrukRyv1Ba0MxoQhZZBs0sYfkssWRP3L8x6xf85fJQavOTMhxJ/zFhpE0geN1sCL1ATKTUK9tPXLJR+6l6jpjTC7AW1PM5LmrCNVXk9Dpov3jGQqj/OM6hlEUaiIx99IcpYhqfg/hOTHha4PuqAakMRsP8LfOCMm+lnv6FF8biC7CpQx8ojYXquOQXLHMEB4juwTWCITUm8n0i2ZP0bD1s5aMKqNWq52Xtozv6Upzd423GB3jFD7fVFTESPYIiA2lNBTtyxnRCUFjtI4Wy/kJccK7cr5rBplVAhVfoTYEHmHdD8Qfg0VbTnRHnsZwntWuXbmlSntLfbAKAifdEMFwjePMNl4jeZtpUdQQNpMphcWIcvVnR8h9r/Liub7k0PA03j8kwWd+jy7QgmjZfPZ6Nw+CqercEtzPzFQIBjQ6TU448kp4Kzr5OdOhSYmucaPbRACEjc9QDbWBqTgY5hCqDB8rIOeM0DHIkFoe02R47x6V62Oe5YimGeKhb6EtAEwQ4fNZaZtQay684OKLii0pnJyr5/Y/mGcITTvJ+lFo2dabkFp3s2V3d1xCDIcNd00cfVdOpTyVcBL3RievVhBBq/+J7gWp2U14dV8FI4zUUYnkGJBUlEjPJO4Fbw49/34nfBfsGqWRih/t3dDhN+1sUedajrhNFTsQ796Yc5Ec+KS2nGnak1wfLho2Osl7AYchvRxYmjj1b37JB5wXKCQa60mYUm2WWBdJSzZfnVkB3W1UskNbZwOmH1q/91Sc2Jm1obtSxBkaqMnWFdq L4GJOxq5 sKeNH+Tx2qAEMlsAMWkOwk0NJZdIrYgN2/sfJCdQ98cGB1Zl7LXt9diNczp3T0bSujiCkjTjBIPMZarNgbv1LhXdG9EpkwP8tadyQxqVcXhdyWQsNBg3n94pdyv4TM8vsu75I/kyOF9HNUOmIRHxuusgjMGOUasjvAeCgZih8TBseJBkZsa9J1TfOvfhqLYUQkN8YgPEE8HMkFH8HfOlMZUOYwxKsHNMnIc5q2sNqfGfDQpKds8vjkQMMm2+Q1CKI3XxlDIfOq9VID5Y76aoswxJ7Bau3xFQGANdtjKuDTIBhFbfl1N2RAwD91jvm0cDSaExLtFrXU+aD5/I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --nextPart5907765.lOV4Wx5bFT Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8"; protected-headers="v1" From: Rolf Eike Beer Subject: Re: API for setting multiple PTEs at once Date: Mon, 20 Feb 2023 09:29:58 +0100 Message-ID: <5649318.DvuYhMxLoT@devpool47> Organization: emlix GmbH In-Reply-To: <0bf59207-838b-2a0b-a95e-925a6bbf1913@ghiti.fr> MIME-Version: 1.0 On Dienstag, 14. Februar 2023 10:55:43 CET Alexandre Ghiti wrote: > Hi Matthew, >=20 > On 2/7/23 21:27, Matthew Wilcox wrote: > > On Thu, Feb 02, 2023 at 09:14:23PM +0000, Matthew Wilcox wrote: > >> For those of you not subscribed, linux-mm is currently discussing > >> how best to handle page faults on large folios. I simply made it work > >> when adding large folio support. Now Yin Fengwei is working on > >> making it fast. > >=20 > > OK, here's an actual implementation: > >=20 > > https://lore.kernel.org/linux-mm/20230207194937.122543-3-willy@infradea= d.o > > rg/ > >=20 > > It survives a run of xfstests. If your architecture doesn't store its > > PFNs at PAGE_SHIFT, you're going to want to implement your own set_ptes= (), > > or you'll see entirely the wrong pages mapped into userspace. You may > > also wish to implement set_ptes() if it can be done more efficiently > > than __pte(pteval(pte) + PAGE_SIZE). > >=20 > > Architectures that implement things like flush_icache_page() and > > update_mmu_cache() may want to propose batched versions of those. > > That's alpha, csky, m68k, mips, nios2, parisc, sh, > > arm, loongarch, openrisc, powerpc, riscv, sparc and xtensa. > > Maintainers BCC'd, mailing lists CC'd. > >=20 > > I'm happy to collect implementations and submit them as part of a v6. >=20 > Please find below the riscv implementation for set_ptes: >=20 > diff --git a/arch/riscv/include/asm/pgtable.h > b/arch/riscv/include/asm/pgtable.h > index ebee56d47003..10bf812776a4 100644 > --- a/arch/riscv/include/asm/pgtable.h > +++ b/arch/riscv/include/asm/pgtable.h > @@ -463,6 +463,20 @@ static inline void set_pte_at(struct mm_struct *mm, > __set_pte_at(mm, addr, ptep, pteval); > } >=20 > +#define set_ptes set_ptes > +static inline void set_ptes(struct mm_struct *mm, unsigned long addr, > + pte_t *ptep, pte_t pte, unsigned int nr) > +{ > + for (;;) { > + set_pte_at(mm, addr, ptep, pte); > + if (--nr =3D=3D 0) > + break; > + ptep++; > + addr +=3D PAGE_SIZE; > + pte =3D __pte(pte_val(pte) + (1 << _PAGE_PFN_SHIFT)); > + } > +} Given that this is the same code as the original version (surprise!), what= =20 about doing something like this in the generic code instead: #ifndef PTE_PAGE_STEP #define PTE_PAGE_STEP PAGE_SIZE #endif [=E2=80=A6] > + pte =3D __pte(pte_val(pte) + PTE_PAGE_STEP); The name of the define is an obvious candidate for bike-shedding, feel free= to=20 name it as you want. Or if that isn't sound enough maybe introduce something like: static inline pte_t set_ptes_next_pte(pte_t pte) { return __pte(pte_val(pte) + (1 << _PAGE_PFN_SHIFT)); } Greetings, Eike =2D-=20 Rolf Eike Beer, emlix GmbH, http://www.emlix.com =46on +49 551 30664-0, Fax +49 551 30664-11 Gothaer Platz 3, 37083 G=C3=B6ttingen, Germany Sitz der Gesellschaft: G=C3=B6ttingen, Amtsgericht G=C3=B6ttingen HR B 3160 Gesch=C3=A4ftsf=C3=BChrung: Heike Jordan, Dr. Uwe Kracke =E2=80=93 Ust-IdNr= =2E: DE 205 198 055 emlix - smart embedded open source --nextPart5907765.lOV4Wx5bFT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iLMEAAEIAB0WIQQ/Uctzh31xzAxFCLur5FH7Xu2t/AUCY/MvhgAKCRCr5FH7Xu2t /E96A/9/8q/Nw4RXmkex96nOqUtHteq72XctyEiwy7GrvS5dHVEeF79ebvwfpWIc Q6IMXFvld2oH9gZNXFrKV13KlDICP8qZscK88++MqxHdNVgMw/o6sU5yAdaiaKEh /bf9Rzx9VJTkDekQ7nP4YDLaAybLYSJ3fXX9PXr+j3HfhBsJxg== =hoWZ -----END PGP SIGNATURE----- --nextPart5907765.lOV4Wx5bFT--