From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2880C5320E for ; Mon, 19 Aug 2024 09:43:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C48B6B0083; Mon, 19 Aug 2024 05:43:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 175866B0085; Mon, 19 Aug 2024 05:43:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0AAC6B0088; Mon, 19 Aug 2024 05:43:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D00116B0083 for ; Mon, 19 Aug 2024 05:43:58 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6B4C516111D for ; Mon, 19 Aug 2024 09:43:58 +0000 (UTC) X-FDA: 82468508556.17.35EF1A8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id F34DFC0010 for ; Mon, 19 Aug 2024 09:43:55 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=b1ZwHD7o; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724060597; a=rsa-sha256; cv=none; b=0gZn08liDIpHkbHw20rMatsokKNIN5yoeNDnV27KbV93NtJBehb962c6QZ2guqIVpxAw/W USgASAx/1XQ7B/rysmlYgQKSHJAZpuxdsngtMHEKBo8Gbc/fq8e1UaGeYn1xN+glAORh1d a/u50jhJ2uxYfkcNCylKpjjmhLtSI04= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=b1ZwHD7o; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724060597; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zZUlSqKu22pdPxNs2Zh0dj9/m0+Zox7XDPT4eW72Vws=; b=AHo0ZcYxsaIfdN20D7DCHOVLFuBIOb1L/cNX9ChJELYufA/cfcZUUlGZ4mfQI65Kojwwek 7Vv4UtXXNHOSPNdaoNYQ8+KYKHU3h0a6plUXJzFmW8qkos5EXXiOg3GkoKjAfruYh7ncnT gsvlhuWL1bIjIcrz7Kuf/TKq2PnIWzQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724060635; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=zZUlSqKu22pdPxNs2Zh0dj9/m0+Zox7XDPT4eW72Vws=; b=b1ZwHD7oKuKhr6gUPAua66pyk7wnV8mz3kBGuq5Wg7ndaVjJrZ3QS/nGIJyNzbAMAkJRMC 9gr3U0mmEfjFFNDaPMvgSE0wZLVvXPf/NuSA1695y5LDQVTXNdQFlsPLd7xFenA4OltkBd kHWjFepYA5ASAh5dWjnujKPYp4mts3k= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-693-kU7AFdaiNS6IzUletPO5xA-1; Mon, 19 Aug 2024 05:43:53 -0400 X-MC-Unique: kU7AFdaiNS6IzUletPO5xA-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3718e1d1847so2395948f8f.1 for ; Mon, 19 Aug 2024 02:43:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724060632; x=1724665432; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=zZUlSqKu22pdPxNs2Zh0dj9/m0+Zox7XDPT4eW72Vws=; b=YJ6jLVmpZft9yN52IL4Foi68Det0FHCJUs+FCcKJSvrvYJxYBN2e27Mlb7SjU6bcqW OXzbDbLupRM1OIqCnrJTRfymjSfK9SEiVwKUMYfPZgoW4H/ZYcGQAEPMVyP5QWApXg31 p9Rt638oUhu82k2Ws0f1CKF6OLNkubRr4DEfLtEJRj3qKMWUsChG93IE6SEcviaPyj41 QzDEDffit4Qfo9lPuLNoIEm0qBLrB0ILX6AjuZyAdbBRvoCf+cx4LuqBQT5g5A0BVjYC BtwFUCq3rzHfTUysVQGcneW9uuBFi5HTTEokaQxfMJ7hT5b4yjsMOjNUQ6btn6a8cWHM VXjQ== X-Forwarded-Encrypted: i=1; AJvYcCVUHdLWWw5XtzsY9jYLsLYqd9HKiIqEW46BzuX2rdF7Szaf1cOMYQH6LL2k+WnzL4gkOtUP+XEwUdg4R76Qa8SHI3I= X-Gm-Message-State: AOJu0Yw+GVT5egMNsODhsoTYsjBtd/HvdT44+duIfg48YU9OIWq9sus7 nTsZ1mF6tcrMwOqbT9hNi4tv08VE9mV2YSFQU02yithhW/ARRkJFn8AVcSVq1ommDBzTpawwD0E JwAEzY58EbWsRi8f5ypYD9EpNKF+8RiCdVR2mTb3W2ys3PrY3 X-Received: by 2002:adf:fa0c:0:b0:371:8283:94c1 with SMTP id ffacd0b85a97d-371942a0dbfmr9103996f8f.0.1724060632533; Mon, 19 Aug 2024 02:43:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFd+jkvShCgw2C63k2Q1YBdJQPYMgV4Egg4N6s7M5zIJoGdwCLJE9E+RMc07H8J2dfbBTUF9Q== X-Received: by 2002:adf:fa0c:0:b0:371:8283:94c1 with SMTP id ffacd0b85a97d-371942a0dbfmr9103956f8f.0.1724060631934; Mon, 19 Aug 2024 02:43:51 -0700 (PDT) Received: from [100.81.188.195] (ipb218f908.dynamic.kabel-deutschland.de. [178.24.249.8]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a83838c66e2sm612153466b.3.2024.08.19.02.43.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Aug 2024 02:43:51 -0700 (PDT) Message-ID: <5654b71c-1d9d-4c48-b28b-664662da8897@redhat.com> Date: Mon, 19 Aug 2024 11:43:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/4] mm: BUG_ON to avoid NULL deference while __GFP_NOFAIL fails To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: 42.hyeyoo@gmail.com, cl@linux.com, hailong.liu@oppo.com, hch@infradead.org, iamjoonsoo.kim@lge.com, mhocko@suse.com, penberg@kernel.org, rientjes@google.com, roman.gushchin@linux.dev, torvalds@linux-foundation.org, urezki@gmail.com, v-songbaohua@oppo.com, vbabka@suse.cz, virtualization@lists.linux.dev, Christoph Hellwig , Lorenzo Stoakes , Kees Cook , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Jason Wang , Maxime Coquelin , "Michael S. Tsirkin" , Xuan Zhuo References: <20240817062449.21164-1-21cnbao@gmail.com> <20240817062449.21164-4-21cnbao@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240817062449.21164-4-21cnbao@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: awaruecgnyanfq9bf84ipdos99nuas5x X-Rspamd-Queue-Id: F34DFC0010 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1724060635-304813 X-HE-Meta: U2FsdGVkX1/6Yji3boKvI5DteJEhKlsEGZmsI8kT5ye84VdFIE2GMXJSomgYWYbLiLbNGn56OKZerm8KaO6SfN7bhizbnmF8qGWF17XTPD+nA/3RSsBVPokrBlVe8nmTY/N0EORg+3Ft1jJr3l/7/j81ZTa2p1j2L1VJQQVbV5bYw67hj9QDTXglupTRyY4aPxAfzzgPoOl5nxWsu3q3O+FtYLNPCfBIPZ6KMpEkXVXEN2V/aEvC7zxchtQ8Zg1EsWAzVl6SK+YqeIMA5GUmQt8TTjB3pZQX7FmwT0i/lc2v1DPe6TkPD4xKPnn3sMTjF5TQdHWLNWnIp4JSYMTcmQE2W6VwppCYiEsfmBPUJ5Axf+mKoXqHA1O/fZwRlaYbdZS3YXOoQoZhf0K+eOC7L64IAiqswHYKptEdgc2/1Dv11ehW14L8tgcy3EypE/l9E4NjJQpuH7VOmgKyvrogh826KU5KyfoPqeneQ4I/LpVSrYsLguyEUpAuhcbHQQon5KFUEieuBCN0h3nzyY4WPU4oPc2IDqQkwZINkDm+bdcYPw5U8QlNhk01J59dZtmfa62jgUk8S42rJN4nyRnH9zBs0N+G3csP5nTPg1VAI7+8JfXYC119cAnI2b9pedhasMPEsUZwuXyubyLIz4loxstyp1Y4WtDZrbeHJpyr2XuLDoxz3w/pWciP3VeTdERgS2hEkdFc9UzgImjR0nCZvYrKYYaIeSGjvzEtwTZfmFI0MWCkBglCeUFyooHi8GRn2zJngRw3C9osTqCtN+AD5Un81O4yS2GFU0kLBAvcMOXTbEvZLdpmnUciIi3iPoAekd0ad9qLrbZ7aA/9JT2bEBeDllNdMcX/cFMsdg/fF37tU+LezfzJ5QLzXMQ90D0Ae04ahNX007iZB0qeQIaHhj0dgUxh9p1YFAa0OszQ+aYJXQTDna/f+PdThRYnYUgTjBzLQwP4XXxBIFs6ati Xfi5650W jNawfcuzyif37imR1GL0bgAXvIRLbgR5YbKsrTk91nbloT7zYKmwoTSYkZpDuSIU5RZzPJN8T2GZptMgUw3aZ7v7MgZSKBjQGka6447nvVWtFd/GCS+S8hz0INJ99JNDIZa1P5cEbfmzQAT7IhO6+TnYknpRSI14Z/Wl3Sdz24FYr/gp7hmBoNT1d2zWR6GKOHJ104BNVTFiAPXj8qoQopjunX8mOasxP8G26en4I+wV67xC8uRTv1WQHJ3jHUPlsZxl5ZPXHpmdsElbf+6rNUtuEAZl6TLKtaXSTnwyzYFsgEWRuxlKhnu26bM+dziCRAjnz5cDn1auIR5u864YiNUu11d1W2sG0Gdmnw2DEUirvNjVneer/Tjn9IbSZW78q/agQbY8DFr3hdMiFkm75g6ndMrXpsDOzMxW1XXsxnFRxZ3zizy9/ziJa/WHvKu2vatoAukNWj/sRXZVuJIV6OMGkiYSAo/uNZwZzH2tLPXRx7o58raFEWexzksx9fcMoMWVuKSYH15211MeX6xdhx/T0hYbwffD9JBUyFK4BK+NdicS6js/iPy+ziHUc/p8pEVM/3H5SLfHqrJjwXY/W90+vjmzSNnOEFKfop2kglSWYRGXSdMfWPEoEoe9krA3C5oicrwZXAUHMWFfedQ0UwHYTaitd63A+Jl0C5YV2u/1ZpMm+8C2BtLYHY6VLz/jEjX5wvOksvKkVz2PNnLzXEzRDC/eBTtxVV5KQSZEp6yvwPAIGxmFlqJFOluyJhFk8OoXCZMe4TJDObHqwiexry/nOlgASJq+cDjo37T1ZfN2/rhI+FtobA8uUKdOpQp6iEdKAQmYSPcu0YQCc2fhPO2I6PHvyM5f+BDyIGV9jUwTMyQ1l7chIDqd1QyRySVpiepWofxh44fXP8M1PDBTZKOtE/nUSABc1q3kJBIWhf8mzbdMPHkfv8iKaQzKTZ8abz/QRIgqK+HAB3Wc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.08.24 08:24, Barry Song wrote: > From: Barry Song > > We have cases we still fail though callers might have __GFP_NOFAIL. Since > they don't check the return, we are exposed to the security risks for NULL > deference. > > Though BUG_ON() is not encouraged by Linus, this is an unrecoverable > situation. > > Christoph Hellwig: > The whole freaking point of __GFP_NOFAIL is that callers don't handle > allocation failures. So in fact a straight BUG is the right thing > here. > > Vlastimil Babka: > It's just not a recoverable situation (WARN_ON is for recoverable > situations). The caller cannot handle allocation failure and at the same > time asked for an impossible allocation. BUG_ON() is a guaranteed oops > with stracktrace etc. We don't need to hope for the later NULL pointer > dereference (which might if really unlucky happen from a different > context where it's no longer obvious what lead to the allocation failing). > > Michal Hocko: > Linus tends to be against adding new BUG() calls unless the failure is > absolutely unrecoverable (e.g. corrupted data structures etc.). I am > not sure how he would look at simply incorrect memory allocator usage to > blow up the kernel. Now the argument could be made that those failures > could cause subtle memory corruptions or even be exploitable which might > be a sufficient reason to stop them early. > > Signed-off-by: Barry Song > Reviewed-by: Christoph Hellwig > Acked-by: Vlastimil Babka > Acked-by: Michal Hocko > Cc: Uladzislau Rezki (Sony) > Cc: Lorenzo Stoakes > Cc: Christoph Lameter > Cc: Pekka Enberg > Cc: David Rientjes > Cc: Joonsoo Kim > Cc: Roman Gushchin > Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> > Cc: Linus Torvalds > Cc: Kees Cook > Cc: "Eugenio Pérez" > Cc: Hailong.Liu > Cc: Jason Wang > Cc: Maxime Coquelin > Cc: "Michael S. Tsirkin" > Cc: Xuan Zhuo > --- > include/linux/slab.h | 4 +++- > mm/page_alloc.c | 4 +++- > mm/util.c | 1 + > 3 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/include/linux/slab.h b/include/linux/slab.h > index c9cb42203183..4a4d1fdc2afe 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -827,8 +827,10 @@ kvmalloc_array_node_noprof(size_t n, size_t size, gfp_t flags, int node) > { > size_t bytes; > > - if (unlikely(check_mul_overflow(n, size, &bytes))) > + if (unlikely(check_mul_overflow(n, size, &bytes))) { > + BUG_ON(flags & __GFP_NOFAIL); > return NULL; > + } > > return kvmalloc_node_noprof(bytes, flags, node); > } > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 60742d057b05..d2c37f8f8d09 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -4668,8 +4668,10 @@ struct page *__alloc_pages_noprof(gfp_t gfp, unsigned int order, > * There are several places where we assume that the order value is sane > * so bail out early if the request is out of bound. > */ > - if (WARN_ON_ONCE_GFP(order > MAX_PAGE_ORDER, gfp)) > + if (WARN_ON_ONCE_GFP(order > MAX_PAGE_ORDER, gfp)) { > + BUG_ON(gfp & __GFP_NOFAIL); > return NULL; > + } > > gfp &= gfp_allowed_mask; > /* > diff --git a/mm/util.c b/mm/util.c > index ac01925a4179..678c647b778f 100644 > --- a/mm/util.c > +++ b/mm/util.c > @@ -667,6 +667,7 @@ void *__kvmalloc_node_noprof(DECL_BUCKET_PARAMS(size, b), gfp_t flags, int node) > > /* Don't even allow crazy sizes */ > if (unlikely(size > INT_MAX)) { > + BUG_ON(flags & __GFP_NOFAIL); No new BUG_ON please. WARN_ON_ONCE() + recovery code might be suitable here. -- Cheers, David / dhildenb