From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f180.google.com (mail-pf0-f180.google.com [209.85.192.180]) by kanga.kvack.org (Postfix) with ESMTP id 0A56E6B0257 for ; Thu, 3 Dec 2015 13:37:01 -0500 (EST) Received: by pfnn128 with SMTP id n128so12382536pfn.0 for ; Thu, 03 Dec 2015 10:37:00 -0800 (PST) Received: from mail-pa0-x235.google.com (mail-pa0-x235.google.com. [2607:f8b0:400e:c03::235]) by mx.google.com with ESMTPS id t72si13449759pfa.153.2015.12.03.10.37.00 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Dec 2015 10:37:00 -0800 (PST) Received: by pabfh17 with SMTP id fh17so75219937pab.0 for ; Thu, 03 Dec 2015 10:37:00 -0800 (PST) Message-ID: <56608BCA.3030303@linaro.org> Date: Thu, 03 Dec 2015 10:36:58 -0800 From: "Shi, Yang" MIME-Version: 1.0 Subject: Re: [PATCH V2 1/7] trace/events: Add gup trace events References: <1449096813-22436-1-git-send-email-yang.shi@linaro.org> <1449096813-22436-2-git-send-email-yang.shi@linaro.org> <20151202230758.0411d8c9@grimm.local.home> In-Reply-To: <20151202230758.0411d8c9@grimm.local.home> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Steven Rostedt Cc: akpm@linux-foundation.org, mingo@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linaro-kernel@lists.linaro.org On 12/2/2015 8:07 PM, Steven Rostedt wrote: > On Wed, 2 Dec 2015 14:53:27 -0800 > Yang Shi wrote: > >> page-faults events record the invoke to handle_mm_fault, but the invoke >> may come from do_page_fault or gup. In some use cases, the finer event count >> mey be needed, so add trace events support for: >> >> __get_user_pages >> __get_user_pages_fast >> fixup_user_fault >> >> Signed-off-by: Yang Shi >> --- >> include/trace/events/gup.h | 71 ++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 71 insertions(+) >> create mode 100644 include/trace/events/gup.h >> >> diff --git a/include/trace/events/gup.h b/include/trace/events/gup.h >> new file mode 100644 >> index 0000000..03a4674 >> --- /dev/null >> +++ b/include/trace/events/gup.h >> @@ -0,0 +1,71 @@ >> +#undef TRACE_SYSTEM >> +#define TRACE_SYSTEM gup >> + >> +#if !defined(_TRACE_GUP_H) || defined(TRACE_HEADER_MULTI_READ) >> +#define _TRACE_GUP_H >> + >> +#include >> +#include >> + >> +TRACE_EVENT(gup_fixup_user_fault, >> + >> + TP_PROTO(struct task_struct *tsk, struct mm_struct *mm, >> + unsigned long address, unsigned int fault_flags), >> + >> + TP_ARGS(tsk, mm, address, fault_flags), > > Arges added and not used by TP_fast_assign(), this will slow down the > code while tracing is enabled, as they need to be added to the trace > function call. > >> + >> + TP_STRUCT__entry( >> + __field( unsigned long, address ) >> + ), >> + >> + TP_fast_assign( >> + __entry->address = address; >> + ), >> + >> + TP_printk("address=%lx", __entry->address) >> +); >> + >> +TRACE_EVENT(gup_get_user_pages, >> + >> + TP_PROTO(struct task_struct *tsk, struct mm_struct *mm, >> + unsigned long start, unsigned long nr_pages), >> + >> + TP_ARGS(tsk, mm, start, nr_pages), > > Here too but this is worse. See below. > >> + >> + TP_STRUCT__entry( >> + __field( unsigned long, start ) >> + __field( unsigned long, nr_pages ) >> + ), >> + >> + TP_fast_assign( >> + __entry->start = start; >> + __entry->nr_pages = nr_pages; >> + ), >> + >> + TP_printk("start=%lx nr_pages=%lu", __entry->start, __entry->nr_pages) >> +); >> + >> +TRACE_EVENT(gup_get_user_pages_fast, >> + >> + TP_PROTO(unsigned long start, int nr_pages, int write, >> + struct page **pages), >> + >> + TP_ARGS(start, nr_pages, write, pages), > > This and the above "gup_get_user_pages" have the same entry field, > assign and printk. They should be combined into a DECLARE_EVENT_CLASS() > and two DEFINE_EVENT()s. That will save on size as the > DECLARE_EVENT_CLASS() is the biggest part of each TRACE_EVENT(). Thanks for the suggestion, will fix them in V3. Regards, Yang > > -- Steve > > >> + >> + TP_STRUCT__entry( >> + __field( unsigned long, start ) >> + __field( unsigned long, nr_pages ) >> + ), >> + >> + TP_fast_assign( >> + __entry->start = start; >> + __entry->nr_pages = nr_pages; >> + ), >> + >> + TP_printk("start=%lx nr_pages=%lu", __entry->start, __entry->nr_pages) >> +); >> + >> +#endif /* _TRACE_GUP_H */ >> + >> +/* This part must be outside protection */ >> +#include > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org