* [PATCH] mm: make sure isolate_lru_page() is never called for tail page
@ 2015-12-16 14:29 Kirill A. Shutemov
2015-12-16 14:47 ` Michal Hocko
0 siblings, 1 reply; 3+ messages in thread
From: Kirill A. Shutemov @ 2015-12-16 14:29 UTC (permalink / raw)
To: Andrew Morton; +Cc: Michal Hocko, linux-mm, Kirill A. Shutemov
The VM_BUG_ON_PAGE() would catch such cases if any still exists.
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
---
mm/vmscan.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 964390906167..05dd182f04fd 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1436,6 +1436,7 @@ int isolate_lru_page(struct page *page)
int ret = -EBUSY;
VM_BUG_ON_PAGE(!page_count(page), page);
+ VM_BUG_ON_PAGE(PageTail(page), page);
if (PageLRU(page)) {
struct zone *zone = page_zone(page);
--
2.6.2
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mm: make sure isolate_lru_page() is never called for tail page
2015-12-16 14:29 [PATCH] mm: make sure isolate_lru_page() is never called for tail page Kirill A. Shutemov
@ 2015-12-16 14:47 ` Michal Hocko
2015-12-22 15:57 ` Vlastimil Babka
0 siblings, 1 reply; 3+ messages in thread
From: Michal Hocko @ 2015-12-16 14:47 UTC (permalink / raw)
To: Kirill A. Shutemov; +Cc: Andrew Morton, linux-mm
On Wed 16-12-15 16:29:30, Kirill A. Shutemov wrote:
> The VM_BUG_ON_PAGE() would catch such cases if any still exists.
Thanks, this better than a silent breakage.
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Michal Hocko <mhocko@suse.com>
> ---
> mm/vmscan.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 964390906167..05dd182f04fd 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -1436,6 +1436,7 @@ int isolate_lru_page(struct page *page)
> int ret = -EBUSY;
>
> VM_BUG_ON_PAGE(!page_count(page), page);
> + VM_BUG_ON_PAGE(PageTail(page), page);
>
> if (PageLRU(page)) {
> struct zone *zone = page_zone(page);
> --
> 2.6.2
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm: make sure isolate_lru_page() is never called for tail page
2015-12-16 14:47 ` Michal Hocko
@ 2015-12-22 15:57 ` Vlastimil Babka
0 siblings, 0 replies; 3+ messages in thread
From: Vlastimil Babka @ 2015-12-22 15:57 UTC (permalink / raw)
To: Michal Hocko, Kirill A. Shutemov; +Cc: Andrew Morton, linux-mm
On 12/16/2015 03:47 PM, Michal Hocko wrote:
> On Wed 16-12-15 16:29:30, Kirill A. Shutemov wrote:
>> The VM_BUG_ON_PAGE() would catch such cases if any still exists.
>
> Thanks, this better than a silent breakage.
>
>> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>
> Acked-by: Michal Hocko <mhocko@suse.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
>
>> ---
>> mm/vmscan.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/mm/vmscan.c b/mm/vmscan.c
>> index 964390906167..05dd182f04fd 100644
>> --- a/mm/vmscan.c
>> +++ b/mm/vmscan.c
>> @@ -1436,6 +1436,7 @@ int isolate_lru_page(struct page *page)
>> int ret = -EBUSY;
>>
>> VM_BUG_ON_PAGE(!page_count(page), page);
>> + VM_BUG_ON_PAGE(PageTail(page), page);
>>
>> if (PageLRU(page)) {
>> struct zone *zone = page_zone(page);
>> --
>> 2.6.2
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-22 15:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-16 14:29 [PATCH] mm: make sure isolate_lru_page() is never called for tail page Kirill A. Shutemov
2015-12-16 14:47 ` Michal Hocko
2015-12-22 15:57 ` Vlastimil Babka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).