From: Vlastimil Babka <vbabka@suse.cz>
To: Ben Hutchings <ben@decadent.org.uk>, linux-mm@kvack.org
Cc: xen-devel@lists.xenproject.org
Subject: Re: [PATCH] mm: Fix missing #include in <linux/mmdebug.h>
Date: Mon, 4 Jan 2016 15:08:13 +0100 [thread overview]
Message-ID: <568A7CCD.2090407@suse.cz> (raw)
In-Reply-To: <20151219203034.GR28542@decadent.org.uk>
On 12/19/2015 09:30 PM, Ben Hutchings wrote:
> The various VM_WARN_ON/VM_BUG_ON macros depend on those defined by
> <linux/bug.h>. Most users already include those, but not all; for
> example:
>
> CC arch/arm64/xen/../../arm/xen/grant-table.o
> In file included from arch/arm64/include/../../arm/include/asm/xen/page.h:5:0,
> from arch/arm64/include/asm/xen/page.h:1,
> from include/xen/page.h:28,
> from arch/arm64/xen/../../arm/xen/grant-table.c:33:
> arch/arm64/include/asm/pgtable.h: In function 'set_pte_at':
> arch/arm64/include/asm/pgtable.h:281:3: error: implicit declaration of function 'BUILD_BUG_ON_INVALID' [-Werror=implicit-function-declaration]
> VM_WARN_ONCE(!pte_young(pte),
>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
> ---
> include/linux/mmdebug.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h
> index 877ef22..772362a 100644
> --- a/include/linux/mmdebug.h
> +++ b/include/linux/mmdebug.h
> @@ -1,6 +1,7 @@
> #ifndef LINUX_MM_DEBUG_H
> #define LINUX_MM_DEBUG_H 1
>
> +#include <linux/bug.h>
> #include <linux/stringify.h>
>
> struct page;
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-01-04 14:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-19 20:30 [PATCH] mm: Fix missing #include in <linux/mmdebug.h> Ben Hutchings
2016-01-04 14:08 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568A7CCD.2090407@suse.cz \
--to=vbabka@suse.cz \
--cc=ben@decadent.org.uk \
--cc=linux-mm@kvack.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).