From: Rik van Riel <riel@redhat.com>
To: Liang Chen <liangchen.linux@gmail.com>, linux-mm@kvack.org
Cc: mgorman@suse.de, akpm@linux-foundation.org,
n-horiguchi@ah.jp.nec.com, linux-kernel@vger.kernel.org,
Gavin Guo <gavin.guo@canonical.com>
Subject: Re: [PATCH] mm: mempolicy: skip non-migratable VMAs when setting MPOL_MF_LAZY
Date: Wed, 6 Jan 2016 10:34:08 -0500 [thread overview]
Message-ID: <568D33F0.7080302@redhat.com> (raw)
In-Reply-To: <1452089927-22039-1-git-send-email-liangchen.linux@gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 01/06/2016 09:18 AM, Liang Chen wrote:
> MPOL_MF_LAZY is not visible from userspace since 'commit
> a720094ded8c ("mm: mempolicy: Hide MPOL_NOOP and MPOL_MF_LAZY from
> userspace for now")' , but it should still skip non-migratable
> VMAs.
The changelog could use a better description of exactly
what the issue is, and why calling change_prot_numa
on a non-migratable VMA is causing problems.
> Signed-off-by: Liang Chen <liangchen.linux@gmail.com>
> Signed-off-by: Gavin Guo <gavin.guo@canonical.com>
For the code itself:
Acked-by: Rik van Riel <riel@redhat.com>
Please resubmit with a better changelog.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBCAAGBQJWjTPwAAoJEM553pKExN6DCncIAKYtabnc7WjsI8/yzc0/qqYR
s92KJjztJ2RiaMhioa6xO1aGh9c00oszHvbZfFlYFJVWn/MsGB83eVQ0KymYLOdx
VyYP59Oe0oWvZagF4bvj7KEZVF35GFuUGOekLfbYihUw6VTgPE38cwAx9stIBTyf
CBm5XT0WdPLWaJrxYl5aJlbdQiJ7BKxQIBx7yyLV8tAgw0KVwEmPpgfftjAI1oIq
ItdrGDIqtOvb6vCc/5DJHT7+6b0ObwcpWWm4rE7QAc7OxyUUXbQydt/OKYXMhbUR
j6wcfHutHW2dcZko5iln7oN9DvBlYnXVSmSa4WJxgavtbL0abTaJGpJLE61pWQQ=
=sCoV
-----END PGP SIGNATURE-----
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-01-06 15:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 14:18 [PATCH] mm: mempolicy: skip non-migratable VMAs when setting MPOL_MF_LAZY Liang Chen
2016-01-06 15:34 ` Rik van Riel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568D33F0.7080302@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=gavin.guo@canonical.com \
--cc=liangchen.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).