From: Mike Kravetz <mike.kravetz@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Hugh Dickins <hughd@google.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Hillf Danton <hillf.zj@alibaba-inc.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [PATCH] mm/hugetlbfs: Unmap pages if page fault raced with hole punch
Date: Mon, 11 Jan 2016 19:21:15 -0800 [thread overview]
Message-ID: <5694712B.6040705@oracle.com> (raw)
In-Reply-To: <20160111182010.bc4e171b.akpm@linux-foundation.org>
On 01/11/2016 06:20 PM, Andrew Morton wrote:
> On Mon, 11 Jan 2016 17:36:43 -0800 Mike Kravetz <mike.kravetz@oracle.com> wrote:
>
>>>
>>> I'll mark this patch as "pending, awaiting Mike's go-ahead".
>>>
>>
>> When this patch was originally submitted, bugs were discovered in the
>> hugetlb_vmdelete_list routine. So, the patch "Fix bugs in
>> hugetlb_vmtruncate_list" was created.
>>
>> I have retested the changes in this patch specifically dealing with
>> page fault/hole punch race on top of the new hugetlb_vmtruncate_list
>> routine. Everything looks good.
>>
>> How would you like to proceed with the patch?
>> - Should I create a series with the hugetlb_vmtruncate_list split out?
>> - Should I respin with hugetlb_vmtruncate_list patch applied?
>>
>> Just let me know what is easiest/best for you.
>
> If you're saying that
> http://ozlabs.org/~akpm/mmots/broken-out/mm-mempolicy-skip-non-migratable-vmas-when-setting-mpol_mf_lazy.patch
That should be,
http://ozlabs.org/~akpm/mmots/broken-out/mm-hugetlbfs-fix-bugs-in-hugetlb_vmtruncate_list.patch
> and
> http://ozlabs.org/~akpm/mmots/broken-out/mm-hugetlbfs-unmap-pages-if-page-fault-raced-with-hole-punch.patch
> are the final everything-works versions then we're all good to go now.
>
The only thing that 'might' be an issue is the new reference to
hugetlb_vmdelete_list() from remove_inode_hugepages().
hugetlb_vmdelete_list() was after remove_inode_hugepages() in the source
file.
The original patch moved hugetlb_vmdelete_list() to satisfy the new
reference. I can not tell if that was taken into account in the way the
patches were pulled into your tree. Will certainly know when it comes
time to build.
--
Mike Kravetz
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-01-12 3:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 22:37 [PATCH] mm/hugetlbfs: Unmap pages if page fault raced with hole punch Mike Kravetz
2016-01-07 8:06 ` Hillf Danton
2016-01-07 16:46 ` Mike Kravetz
2016-01-08 4:39 ` Mike Kravetz
2016-01-08 6:25 ` Hillf Danton
2016-01-11 22:35 ` Andrew Morton
2016-01-11 23:38 ` Mike Kravetz
2016-01-12 0:29 ` Andrew Morton
2016-01-12 1:36 ` Mike Kravetz
2016-01-12 2:20 ` Andrew Morton
2016-01-12 3:21 ` Mike Kravetz [this message]
2016-01-12 4:35 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5694712B.6040705@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=dave@stgolabs.net \
--cc=hillf.zj@alibaba-inc.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).