From: David Vrabel <david.vrabel@citrix.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>, linux-mm@kvack.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
David Vrabel <david.vrabel@citrix.com>,
xen-devel@lists.xenproject.org,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [Xen-devel] [PATCH] cleancache: constify cleancache_ops structure
Date: Thu, 21 Jan 2016 10:45:59 +0000 [thread overview]
Message-ID: <56A0B6E7.9040201@citrix.com> (raw)
In-Reply-To: <1450904784-17139-1-git-send-email-Julia.Lawall@lip6.fr>
On 23/12/15 21:06, Julia Lawall wrote:
> The cleancache_ops structure is never modified, so declare it as const.
>
> This also removes the __read_mostly declaration on the cleancache_ops
> variable declaration, since it seems redundant with const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
>
> Not sure that the __read_mostly change is correct. Does it apply to the
> variable, or to what the variable points to?
The variable, so...
> --- a/mm/cleancache.c
> +++ b/mm/cleancache.c
> @@ -22,7 +22,7 @@
> * cleancache_ops is set by cleancache_register_ops to contain the pointers
> * to the cleancache "backend" implementation functions.
> */
> -static struct cleancache_ops *cleancache_ops __read_mostly;
> +static const struct cleancache_ops *cleancache_ops;
...you want to retain the __read_mostly here.
David
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-01-21 10:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 21:06 [PATCH] cleancache: constify cleancache_ops structure Julia Lawall
2016-01-20 22:20 ` Konrad Rzeszutek Wilk
2016-01-21 20:00 ` Rasmus Villemoes
2016-01-21 20:03 ` Julia Lawall
2016-01-21 10:45 ` David Vrabel [this message]
2016-01-21 11:06 ` [Xen-devel] " Julia Lawall
2016-01-21 15:47 ` [Xen-devel] [PATCH v2] " Julia Lawall
2016-01-21 21:35 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A0B6E7.9040201@citrix.com \
--to=david.vrabel@citrix.com \
--cc=Julia.Lawall@lip6.fr \
--cc=boris.ostrovsky@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).