linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@linux.intel.com>
To: Khalid Aziz <khalid.aziz@oracle.com>,
	David Miller <davem@davemloft.net>,
	luto@amacapital.net
Cc: rob.gardner@oracle.com, corbet@lwn.net,
	akpm@linux-foundation.org, dingel@linux.vnet.ibm.com,
	bob.picco@oracle.com, kirill.shutemov@linux.intel.com,
	aneesh.kumar@linux.vnet.ibm.com, aarcange@redhat.com,
	arnd@arndb.de, sparclinux@vger.kernel.org, mhocko@suse.cz,
	chris.hyser@oracle.com, richard@nod.at, vbabka@suse.cz,
	koct9i@gmail.com, oleg@redhat.com, gthelen@google.com,
	jack@suse.cz, xiexiuqi@huawei.com, Vineet.Gupta1@synopsys.com,
	luto@kernel.org, ebiederm@xmission.com, bsegall@google.com,
	geert@linux-m68k.org, dave@stgolabs.net, adobriyan@gmail.com,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, linux-arch@vger.kernel.org,
	linux-api@vger.kernel.org
Subject: Re: [PATCH v2] sparc64: Add support for Application Data Integrity (ADI)
Date: Mon, 7 Mar 2016 14:40:57 -0800	[thread overview]
Message-ID: <56DE0379.8020907@linux.intel.com> (raw)
In-Reply-To: <56DDDA78.2070106@oracle.com>

On 03/07/2016 11:46 AM, Khalid Aziz wrote:
> On 03/07/2016 12:22 PM, David Miller wrote:
>> Khalid, maybe you should share notes with the folks working on x86
>> protection keys.
> 
> Good idea. Sparc ADI feature is indeed similar to x86 protection keys
> sounds like.

There are definitely some similarities.  But protection keys doesn't
have any additional tables in which to keep metadata.  It keeps all of
its data in the page tables.  It also doesn't have an impact on the
virtual address layout.

But, it does have metadata to store in the VMA, has a special
siginfo->si_code, and it uses mprotect() (although a new pkey_mprotect()
variant that takes an extra argument).

Protection Keys are described a bit more here:

> http://git.kernel.org/cgit/linux/kernel/git/daveh/x86-pkeys.git/tree/Documentation/x86/protection-keys.txt?h=pkeys-v025&id=1b5b8a8836de8eb667027178b4820665dea5a038

MPX is another Intel feature separate from protection keys, but *it* has
some tables that it keep its metadata memory and special special
instructions to move metadata in and out of it.  It also has a prctl()
to enable/disable kernel assistance for the feature.  Unlike ADI, the
tables are exposed (and accessible) to user applications in normal
application memory.

MPX's documentation is here:

> http://git.kernel.org/cgit/linux/kernel/git/daveh/x86-pkeys.git/tree/Documentation/x86/intel_mpx.txt

Overall, I'm not seeing much overlap at all between the features, honestly.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2016-03-07 22:41 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-02 20:39 [PATCH v2] sparc64: Add support for Application Data Integrity (ADI) Khalid Aziz
2016-03-02 23:08 ` Julian Calaby
2016-03-03  0:25   ` Khalid Aziz
2016-03-03  0:48     ` Julian Calaby
2016-03-03 17:28       ` Khalid Aziz
2016-03-06  4:07 ` David Miller
2016-03-07 15:07   ` Khalid Aziz
2016-03-07 15:30     ` Rob Gardner
2016-03-07 15:43       ` Andy Lutomirski
2016-03-07 16:06         ` Khalid Aziz
2016-03-07 17:46           ` Dave Hansen
2016-03-07 17:53             ` Andy Lutomirski
2016-03-07 18:12               ` Dave Hansen
2016-03-07 18:39                 ` Khalid Aziz
2016-03-07 18:53                   ` Andy Lutomirski
2016-03-07 19:22                     ` David Miller
2016-03-07 19:46                       ` Khalid Aziz
2016-03-07 22:40                         ` Dave Hansen [this message]
2016-03-08  1:31                   ` Rob Gardner
2016-03-07 21:06             ` Khalid Aziz
2016-03-08 19:57               ` David Miller
2016-03-08 20:16                 ` Khalid Aziz
2016-03-08 20:27                   ` David Miller
2016-03-08 20:59                     ` Khalid Aziz
2016-03-07 15:45       ` Khalid Aziz
2016-03-07 16:45     ` David Miller
2016-03-07 17:51       ` Khalid Aziz
2016-03-07 16:56     ` David Miller
2016-03-07 18:04       ` Khalid Aziz
2016-03-07 18:08         ` Andy Lutomirski
2016-03-07 18:22           ` Khalid Aziz
2016-03-07 18:49             ` Andy Lutomirski
2016-03-07 19:19               ` David Miller
2016-03-07 19:44               ` Khalid Aziz
2016-03-07 19:54                 ` Andy Lutomirski
2016-03-07 20:41                   ` Khalid Aziz
2016-03-07 20:58                     ` David Miller
2016-03-07 21:02                       ` Andy Lutomirski
2016-03-07 21:09                       ` Khalid Aziz
2016-03-07 23:34                       ` James Morris
2016-03-07 23:48                   ` James Morris
2016-03-08  9:33                     ` James Morris
2016-03-07 18:09         ` Rob Gardner
2016-03-07 18:24           ` Khalid Aziz
2016-03-07 19:16             ` David Miller
2016-03-07 21:33               ` Khalid Aziz
2016-03-07 21:38                 ` David Miller
2016-03-07 23:13                   ` Rob Gardner
2016-03-08  4:13                     ` David Miller
2016-03-07 23:12                 ` Rob Gardner
2016-03-07 23:27                   ` Khalid Aziz
2016-03-08  0:21               ` Khalid Aziz
2016-03-08  4:24                 ` David Miller
2016-03-07 23:32             ` Rob Gardner
2016-03-07 19:09         ` David Miller
2016-03-07 21:27           ` Khalid Aziz
2016-03-07 21:34             ` David Miller
2016-03-07 22:30               ` Khalid Aziz
2016-03-07 17:32 ` Dave Hansen
2016-03-07 17:35 ` Dave Hansen
2016-03-07 18:15   ` Khalid Aziz
2016-03-07 19:06   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56DE0379.8020907@linux.intel.com \
    --to=dave.hansen@linux.intel.com \
    --cc=Vineet.Gupta1@synopsys.com \
    --cc=aarcange@redhat.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=arnd@arndb.de \
    --cc=bob.picco@oracle.com \
    --cc=bsegall@google.com \
    --cc=chris.hyser@oracle.com \
    --cc=corbet@lwn.net \
    --cc=dave@stgolabs.net \
    --cc=davem@davemloft.net \
    --cc=dingel@linux.vnet.ibm.com \
    --cc=ebiederm@xmission.com \
    --cc=geert@linux-m68k.org \
    --cc=gthelen@google.com \
    --cc=jack@suse.cz \
    --cc=khalid.aziz@oracle.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=koct9i@gmail.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@amacapital.net \
    --cc=luto@kernel.org \
    --cc=mhocko@suse.cz \
    --cc=oleg@redhat.com \
    --cc=richard@nod.at \
    --cc=rob.gardner@oracle.com \
    --cc=sparclinux@vger.kernel.org \
    --cc=vbabka@suse.cz \
    --cc=xiexiuqi@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).