[PATCH 1/1] mm/page_alloc: Remove useless parameter of __free_pages_boot_core

[PATCH 1/1] mm/page_alloc: Remove useless parameter of __free_pages_boot_core

[Li Zhang]

From: Li Zhang <zhlcindy@linux.vnet.ibm.com>

__free_pages_boot_core has parameter pfn which is not used at all.
So this patch is to make it clean.

Signed-off-by: Li Zhang <zhlcindy@linux.vnet.ibm.com>
---
 mm/page_alloc.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index a762be5..8c0affe 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1056,8 +1056,7 @@ static void __free_pages_ok(struct page *page, unsigned int order)
 	local_irq_restore(flags);
 }
 
-static void __init __free_pages_boot_core(struct page *page,
-					unsigned long pfn, unsigned int order)
+static void __init __free_pages_boot_core(struct page *page, unsigned int order)
 {
 	unsigned int nr_pages = 1 << order;
 	struct page *p = page;
@@ -1134,7 +1133,7 @@ void __init __free_pages_bootmem(struct page *page, unsigned long pfn,
 {
 	if (early_page_uninitialised(pfn))
 		return;
-	return __free_pages_boot_core(page, pfn, order);
+	return __free_pages_boot_core(page, order);
 }
 
 /*
@@ -1219,12 +1218,12 @@ static void __init deferred_free_range(struct page *page,
 	if (nr_pages == MAX_ORDER_NR_PAGES &&
 	    (pfn & (MAX_ORDER_NR_PAGES-1)) == 0) {
 		set_pageblock_migratetype(page, MIGRATE_MOVABLE);
-		__free_pages_boot_core(page, pfn, MAX_ORDER-1);
+		__free_pages_boot_core(page, MAX_ORDER-1);
 		return;
 	}
 
-	for (i = 0; i < nr_pages; i++, page++, pfn++)
-		__free_pages_boot_core(page, pfn, 0);
+	for (i = 0; i < nr_pages; i++, page++)
+		__free_pages_boot_core(page, 0);
 }
 
 /* Completion tracking for deferred_init_memmap() threads */
-- 
2.1.0

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH 1/1] mm/page_alloc: Remove useless parameter of __free_pages_boot_core

[zhlcindy]

Sorry, a mail address in TO list is wrong. Correct it.

On 2016-03-24 11:51, Li Zhang wrote:
> From: Li Zhang <zhlcindy@linux.vnet.ibm.com>
> 
> __free_pages_boot_core has parameter pfn which is not used at all.
> So this patch is to make it clean.
> 
> Signed-off-by: Li Zhang <zhlcindy@linux.vnet.ibm.com>
> ---
>  mm/page_alloc.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index a762be5..8c0affe 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -1056,8 +1056,7 @@ static void __free_pages_ok(struct page *page,
> unsigned int order)
>  	local_irq_restore(flags);
>  }
> 
> -static void __init __free_pages_boot_core(struct page *page,
> -					unsigned long pfn, unsigned int order)
> +static void __init __free_pages_boot_core(struct page *page, unsigned
> int order)
>  {
>  	unsigned int nr_pages = 1 << order;
>  	struct page *p = page;
> @@ -1134,7 +1133,7 @@ void __init __free_pages_bootmem(struct page
> *page, unsigned long pfn,
>  {
>  	if (early_page_uninitialised(pfn))
>  		return;
> -	return __free_pages_boot_core(page, pfn, order);
> +	return __free_pages_boot_core(page, order);
>  }
> 
>  /*
> @@ -1219,12 +1218,12 @@ static void __init deferred_free_range(struct
> page *page,
>  	if (nr_pages == MAX_ORDER_NR_PAGES &&
>  	    (pfn & (MAX_ORDER_NR_PAGES-1)) == 0) {
>  		set_pageblock_migratetype(page, MIGRATE_MOVABLE);
> -		__free_pages_boot_core(page, pfn, MAX_ORDER-1);
> +		__free_pages_boot_core(page, MAX_ORDER-1);
>  		return;
>  	}
> 
> -	for (i = 0; i < nr_pages; i++, page++, pfn++)
> -		__free_pages_boot_core(page, pfn, 0);
> +	for (i = 0; i < nr_pages; i++, page++)
> +		__free_pages_boot_core(page, 0);
>  }
> 
>  /* Completion tracking for deferred_init_memmap() threads */

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH 1/1] mm/page_alloc: Remove useless parameter of __free_pages_boot_core

[Pan Xinhui]

On 2016a1'03ae??24ae?JPY 11:51, Li Zhang wrote:
> From: Li Zhang <zhlcindy@linux.vnet.ibm.com>
> 
> __free_pages_boot_core has parameter pfn which is not used at all.
> So this patch is to make it clean.
> 
> Signed-off-by: Li Zhang <zhlcindy@linux.vnet.ibm.com>

Reviewed-by: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>