* [PATCH] writeback: fix the wrong congested state variable definition
@ 2016-03-31 13:19 Kaixu Xia
2016-03-31 16:44 ` Tejun Heo
2016-03-31 18:26 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Kaixu Xia @ 2016-03-31 13:19 UTC (permalink / raw)
To: tj, axboe
Cc: lizefan, jack, linux-mm, akpm, mhocko, neilb, linux-kernel,
xiakaixu
The right variable definition should be wb_congested_state that
include WB_async_congested and WB_sync_congested. So fix it.
Signed-off-by: Kaixu Xia <xiakaixu@huawei.com>
---
mm/backing-dev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index bfbd709..0c6317b 100644
--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -898,7 +898,7 @@ static atomic_t nr_wb_congested[2];
void clear_wb_congested(struct bdi_writeback_congested *congested, int sync)
{
wait_queue_head_t *wqh = &congestion_wqh[sync];
- enum wb_state bit;
+ enum wb_congested_state bit;
bit = sync ? WB_sync_congested : WB_async_congested;
if (test_and_clear_bit(bit, &congested->state))
@@ -911,7 +911,7 @@ EXPORT_SYMBOL(clear_wb_congested);
void set_wb_congested(struct bdi_writeback_congested *congested, int sync)
{
- enum wb_state bit;
+ enum wb_congested_state bit;
bit = sync ? WB_sync_congested : WB_async_congested;
if (!test_and_set_bit(bit, &congested->state))
--
1.8.3.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] writeback: fix the wrong congested state variable definition
2016-03-31 13:19 [PATCH] writeback: fix the wrong congested state variable definition Kaixu Xia
@ 2016-03-31 16:44 ` Tejun Heo
2016-03-31 18:26 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2016-03-31 16:44 UTC (permalink / raw)
To: Kaixu Xia
Cc: axboe, lizefan, jack, linux-mm, akpm, mhocko, neilb, linux-kernel
On Thu, Mar 31, 2016 at 01:19:41PM +0000, Kaixu Xia wrote:
> The right variable definition should be wb_congested_state that
> include WB_async_congested and WB_sync_congested. So fix it.
>
> Signed-off-by: Kaixu Xia <xiakaixu@huawei.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] writeback: fix the wrong congested state variable definition
2016-03-31 13:19 [PATCH] writeback: fix the wrong congested state variable definition Kaixu Xia
2016-03-31 16:44 ` Tejun Heo
@ 2016-03-31 18:26 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2016-03-31 18:26 UTC (permalink / raw)
To: Kaixu Xia, tj; +Cc: lizefan, jack, linux-mm, akpm, mhocko, neilb, linux-kernel
On 03/31/2016 07:19 AM, Kaixu Xia wrote:
> The right variable definition should be wb_congested_state that
> include WB_async_congested and WB_sync_congested. So fix it.
Added, thanks.
--
Jens Axboe
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-31 18:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-31 13:19 [PATCH] writeback: fix the wrong congested state variable definition Kaixu Xia
2016-03-31 16:44 ` Tejun Heo
2016-03-31 18:26 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).