From: David Hildenbrand <david@redhat.com>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Zi Yan <ziy@nvidia.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Barry Song <baohua@kernel.org>, Lance Yang <lance.yang@linux.dev>,
Liam.Howlett@oracle.com
Subject: Re: [PATCH v4 3/4] mm: mprotect: convert to folio_needs_prot_numa()
Date: Tue, 21 Oct 2025 17:01:30 +0200 [thread overview]
Message-ID: <5703e7e6-f037-4b4d-be74-8c256e7a3e10@redhat.com> (raw)
In-Reply-To: <16ca4c3d-7c18-4cb9-bc04-d2eccb5d9b67@lucifer.local>
On 21.10.25 16:56, Lorenzo Stoakes wrote:
> On Tue, Oct 21, 2025 at 08:54:08PM +0800, Kefeng Wang wrote:
>>
>>
>> On 2025/10/21 17:45, Lorenzo Stoakes wrote:
>>> On Tue, Oct 21, 2025 at 10:25:08AM +0100, Lorenzo Stoakes wrote:
>>>> On Tue, Oct 21, 2025 at 11:13:32AM +0200, David Hildenbrand wrote:
>>>>> On 21.10.25 10:41, Kefeng Wang wrote:
>>>>>> Maybe folio_needs_protnone_mapping()?
>>>>>
>>>>> I think prot_numa should be in the name one way or the other, because we
>>>>> also have ordinary PROT_NONE unrealted to NUMA faults.
>>>>
>>>> folio_can_map_prot_numa() semes to me to be the best choice.
>>>>
>>>
>>> I don't want to hold up the series so if you guys feel strongly, leave it
>>> as-is. But this reads better to me.
>>
>> Let's keep things as-is for now.
>
> It'd be nice to have an argument as to why (I did say if you guys had
> strong opinions...), but never mind.
>
folio_can_map_prot_numa() works for me, so we can just use that and call
it a day :)
--
Cheers
David / dhildenb
next prev parent reply other threads:[~2025-10-21 15:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 6:18 [PATCH v4 0/4] mm: some optimizations for prot numa Kefeng Wang
2025-10-20 6:18 ` [PATCH v4 1/4] mm: mprotect: always skip dma pinned folio in prot_numa_skip() Kefeng Wang
2025-10-21 3:06 ` Barry Song
2025-10-20 6:18 ` [PATCH v4 2/4] mm: mprotect: avoid unnecessary struct page accessing if pte_protnone() Kefeng Wang
2025-10-20 12:53 ` Lorenzo Stoakes
2025-10-20 13:08 ` David Hildenbrand
2025-10-20 6:18 ` [PATCH v4 3/4] mm: mprotect: convert to folio_needs_prot_numa() Kefeng Wang
2025-10-20 13:09 ` David Hildenbrand
2025-10-20 13:10 ` Lorenzo Stoakes
2025-10-20 15:14 ` Kefeng Wang
2025-10-20 17:34 ` David Hildenbrand
2025-10-20 17:49 ` Lorenzo Stoakes
2025-10-20 18:12 ` David Hildenbrand
2025-10-20 18:56 ` Lorenzo Stoakes
2025-10-21 8:41 ` Kefeng Wang
2025-10-21 9:13 ` David Hildenbrand
2025-10-21 9:25 ` Lorenzo Stoakes
2025-10-21 9:45 ` Lorenzo Stoakes
2025-10-21 12:54 ` Kefeng Wang
2025-10-21 14:56 ` Lorenzo Stoakes
2025-10-21 15:01 ` David Hildenbrand [this message]
2025-10-21 16:36 ` Lorenzo Stoakes
2025-10-22 0:51 ` Kefeng Wang
2025-10-20 6:18 ` [PATCH v4 4/4] mm: huge_memory: use folio_needs_prot_numa() for pmd folio Kefeng Wang
2025-10-20 13:11 ` David Hildenbrand
2025-10-20 13:15 ` Lorenzo Stoakes
2025-10-20 13:23 ` David Hildenbrand
2025-10-20 15:18 ` Kefeng Wang
2025-10-21 13:37 ` Kefeng Wang
2025-10-21 15:35 ` Lorenzo Stoakes
2025-10-21 15:29 ` Lorenzo Stoakes
2025-10-22 1:33 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5703e7e6-f037-4b4d-be74-8c256e7a3e10@redhat.com \
--to=david@redhat.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=ryan.roberts@arm.com \
--cc=wangkefeng.wang@huawei.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).